Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8BEC43381 for ; Thu, 21 Mar 2019 07:35:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F081218A5 for ; Thu, 21 Mar 2019 07:35:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="WO5YY8os"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="WO5YY8os" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727844AbfCUHfI (ORCPT ); Thu, 21 Mar 2019 03:35:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56686 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfCUHfI (ORCPT ); Thu, 21 Mar 2019 03:35:08 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E726D608FC; Thu, 21 Mar 2019 07:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553153706; bh=3/39Wdkya0HOUTp7jMvtK3ntf+s/eGwHKvzmwCtmjdc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WO5YY8osnUTIxpJXB9EGbl1FQfrPGbBjj4agQLi0rHiEIDhKY0DdPoNm2j4o2HtO4 blWe2ak/JXkqX2VDjnEz7alCSz4U2rOWrXDwkufzDvBj0rWeTbZrJF/SAn7p1n75gj LNpowKuoM+aF+JvQYcu6t4TqeTnRRtt3KOvHMbfw= Received: from x230.qca.qualcomm.com (unknown [195.39.71.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 824F86086B; Thu, 21 Mar 2019 07:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553153706; bh=3/39Wdkya0HOUTp7jMvtK3ntf+s/eGwHKvzmwCtmjdc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WO5YY8osnUTIxpJXB9EGbl1FQfrPGbBjj4agQLi0rHiEIDhKY0DdPoNm2j4o2HtO4 blWe2ak/JXkqX2VDjnEz7alCSz4U2rOWrXDwkufzDvBj0rWeTbZrJF/SAn7p1n75gj LNpowKuoM+aF+JvQYcu6t4TqeTnRRtt3KOvHMbfw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 824F86086B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Sergey Matyukevich Cc: "linux-wireless\@vger.kernel.org" , Igor Mitsyanko Subject: Re: [PATCH 12/14] qtnfmac: fix debugfs entries for multiple cards on the same host References: <20190320100340.14168-1-sergey.matyukevich.os@quantenna.com> <20190320100340.14168-13-sergey.matyukevich.os@quantenna.com> <874l7xzlmo.fsf@purkki.adurom.net> <20190320151641.3477cx3kuc3ipqam@bars> Date: Thu, 21 Mar 2019 09:35:02 +0200 In-Reply-To: <20190320151641.3477cx3kuc3ipqam@bars> (Sergey Matyukevich's message of "Wed, 20 Mar 2019 15:16:47 +0000") Message-ID: <8736ngsms9.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sergey Matyukevich writes: >> > Fix creation of debugfs entries for qtnfmac wireless card: use separate >> > directories for different wireless cards. This commit enables support >> > for multiple qtnfmac wireless cards on the same PCIe host. >> > >> > Signed-off-by: Sergey Matyukevich >> > --- >> > drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 6 +++++- >> > 1 file changed, 5 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c >> > index b561b75e4433..56fc6d49c121 100644 >> > --- a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c >> > +++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c >> > @@ -130,6 +130,8 @@ static int qtnf_dbg_shm_stats(struct seq_file *s, void *data) >> > >> > int qtnf_pcie_fw_boot_done(struct qtnf_bus *bus) >> > { >> > + struct qtnf_pcie_bus_priv *priv = get_bus_priv(bus); >> > + char card_id[64]; >> > int ret; >> > >> > bus->fw_state = QTNF_FW_STATE_BOOT_DONE; >> > @@ -137,7 +139,9 @@ int qtnf_pcie_fw_boot_done(struct qtnf_bus *bus) >> > if (ret) { >> > pr_err("failed to attach core\n"); >> > } else { >> > - qtnf_debugfs_init(bus, DRV_NAME); >> > + snprintf(card_id, sizeof(card_id), "%s:%s", >> > + DRV_NAME, pci_name(priv->pdev)); >> >> Can you give an example for the path? >> > > For instance: /sys/kernel/debug/qtnfmac_pcie:0000:01:00.0 TBH not really fond of that. What about "/sys/kernel/debug/qtnfmac/pcie:0000:01:00.0"? IIRC iwlwifi used something like that. And please add an example path to the commit log. -- Kalle Valo