Date:   Fri, 22 Mar 2019 11:10:40 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 03/12] mt76usb: change mt76u_fill_rx_sg arguments
Message-ID: <20190322101038.GA22889@localhost.localdomain>
References: <20190321152537.19105-1-sgruszka@redhat.com>
 <20190321152537.19105-4-sgruszka@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS"
Content-Disposition: inline
In-Reply-To: <20190321152537.19105-4-sgruszka@redhat.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--qMm9M+Fa2AknHoGS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> We do not need to pass len and sglen to the function.
> Additionally pass gfp to control allocation context.
>=20
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/mediatek/mt76/usb.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wirel=
ess/mediatek/mt76/usb.c
> index 3f21599d52de..56e7a2ca8930 100644
> --- a/drivers/net/wireless/mediatek/mt76/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/usb.c
> @@ -285,11 +285,13 @@ mt76u_set_endpoints(struct usb_interface *intf,
>  }
> =20
>  static int
> -mt76u_fill_rx_sg(struct mt76_dev *dev, struct mt76u_buf *buf,
> -		 int nsgs, int len, int sglen)
> +mt76u_fill_rx_sg(struct mt76_dev *dev, struct mt76u_buf *buf, int nsgs,
> +		 gfp_t gfp)
>  {
>  	struct mt76_queue *q =3D &dev->q_rx[MT_RXQ_MAIN];
> +	int sglen =3D SKB_WITH_OVERHEAD(q->buf_size);
>  	struct urb *urb =3D buf->urb;
> +

please drop newline here

>  	int i;
> =20
>  	for (i =3D 0; i < nsgs; i++) {
> @@ -297,7 +299,7 @@ mt76u_fill_rx_sg(struct mt76_dev *dev, struct mt76u_b=
uf *buf,
>  		void *data;
>  		int offset;
> =20
> -		data =3D page_frag_alloc(&q->rx_page, len, GFP_ATOMIC);
> +		data =3D page_frag_alloc(&q->rx_page, q->buf_size, gfp);
>  		if (!data)
>  			break;
> =20
> @@ -326,8 +328,7 @@ mt76u_refill_rx(struct mt76_dev *dev, struct mt76_que=
ue *q,
>  		struct mt76u_buf *buf, int nsgs, gfp_t gfp)
>  {
>  	if (dev->usb.sg_en) {
> -		return mt76u_fill_rx_sg(dev, buf, nsgs, q->buf_size,
> -					SKB_WITH_OVERHEAD(q->buf_size));
> +		return mt76u_fill_rx_sg(dev, buf, nsgs, gfp);
>  	} else {
>  		buf->buf =3D page_frag_alloc(&q->rx_page, q->buf_size, gfp);
>  		return buf->buf ? 0 : -ENOMEM;
> --=20
> 2.20.1
>=20

--qMm9M+Fa2AknHoGS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXJS0mgAKCRA6cBh0uS2t
rJigAQCsxg8QaFt93oV5wqN4FuftxtQQnJvLE3uE/iTd6cl+YQEAh0vSVTq4vOvQ
4YmLSHk7Ofsrcc9UJ+O/C69lOKLh1QE=
=8x+M
-----END PGP SIGNATURE-----

--qMm9M+Fa2AknHoGS--