From:   Christian Lamparter <chunkeey@gmail.com>
To:     Tomislav =?utf-8?B?UG/FvmVnYQ==?= <pozega.tomislav@gmail.com>
Cc:     linux-wireless@vger.kernel.org, openwrt-devel@lists.openwrt.org,
        kalle@codeaurora.org
Subject: Re: [PATCH] ath10k: reset chip after supported check
Date:   Fri, 22 Mar 2019 20:25:37 +0100
Message-ID: <3337086.qEUs9xMCTV@debian64>
In-Reply-To: <1553281120-22139-1-git-send-email-pozega.tomislav@gmail.com>
References: <1553281120-22139-1-git-send-email-pozega.tomislav@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Friday, March 22, 2019 7:58:40 PM CET Tomislav Po=C5=BEega wrote:
> When chip reset is done before the chip is checked if supported
> there will be crash. Previous behaviour caused bootloops on
> Archer C7 v1 units, this patch allows clean device boot without
> excluding ath10k driver.
>=20
You need

=46ixes: 1a7fecb766c8 ("ath10k: reset chip before reading chip_id in probe")

too
> Signed-off-by: Tomislav Po=C5=BEega <pozega.tomislav@gmail.com>
> ---
>  drivers/net/wireless/ath/ath10k/pci.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless=
/ath/ath10k/pci.c
> index e24403c..ec681da 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -3619,12 +3619,6 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
>  		goto err_deinit_irq;
>  	}
> =20
> -	ret =3D ath10k_pci_chip_reset(ar);
> -	if (ret) {
> -		ath10k_err(ar, "failed to reset chip: %d\n", ret);
> -		goto err_free_irq;
> -	}
> -
>  	bus_params.dev_type =3D ATH10K_DEV_TYPE_LL;
>  	bus_params.link_can_suspend =3D true;
>  	bus_params.chip_id =3D ath10k_pci_soc_read32(ar, SOC_CHIP_ID_ADDRESS);
> @@ -3639,6 +3633,12 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
>  		goto err_free_irq;
>  	}
> =20
> +	ret =3D ath10k_pci_chip_reset(ar);
> +	if (ret) {
> +		ath10k_err(ar, "failed to reset chip: %d\n", ret);
> +		goto err_free_irq;
> +	}
> +
>  	ret =3D ath10k_core_register(ar, &bus_params);
>  	if (ret) {
>  		ath10k_err(ar, "failed to register driver core: %d\n", ret);
>=20