Date:   Mon, 25 Mar 2019 14:47:35 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: usb: reduce locking in mt76u_tx_tasklet
Message-ID: <20190325134734.GB12885@localhost.localdomain>
References: <cover.1553437543.git.lorenzo@kernel.org>
 <1f489df8bc635660a1d1fb72400e5562504c0555.1553437543.git.lorenzo@kernel.org>
 <20190325125032.GB17956@redhat.com>
 <20190325130035.GA12885@localhost.localdomain>
 <20190325131019.GA19204@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="RASg3xLB4tUQ4RcS"
Content-Disposition: inline
In-Reply-To: <20190325131019.GA19204@redhat.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--RASg3xLB4tUQ4RcS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Mon, Mar 25, 2019 at 02:00:36PM +0100, Lorenzo Bianconi wrote:
> > > On Sun, Mar 24, 2019 at 03:51:43PM +0100, Lorenzo Bianconi wrote:
> > > > +		int idx;
> > > > +
> > > >  		sq =3D &dev->q_tx[i];
> > > >  		q =3D sq->q;
> > > > =20
> > > > -		spin_lock_bh(&q->lock);
> > > > -		while (true) {
> > > > -			if (!q->entry[q->head].done || !q->queued)
> > > > +		while (q->queued > n_queued) {
> > > > +			if (!q->entry[q->head].done)
> > > >  				break;
> > > If you place done =3D false here you will not need additional idx
> > > variable.
> >=20
> > As Felix suggested, I would set done to false at the end of the loop, a=
fter
> > tx_complete_skb
> Why this is needed?=20

logically I think it should be the last thing to do on the current skb but
probably moving it before tx_complete_skb will not make any difference

>=20
> > > >  			dev->drv->tx_complete_skb(dev, i, &entry);
> > > > -			spin_lock_bh(&q->lock);
> > > > +			q->entry[idx].done =3D false;
> > > >  		}
> > > > =20
> > > > +		spin_lock_bh(&q->lock);
> > > This patch does not apply for me as there is missing
> > > mt76_txq_schedule(dev, sq);
> >=20
> > Sorry I forgot to mention this patch is based on
> > https://patchwork.kernel.org/patch/10856027/. Have you applied it?
> No.
>=20
> Stanislaw
>=20

--RASg3xLB4tUQ4RcS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXJjb8wAKCRA6cBh0uS2t
rJUUAP9cheGDoyDRbGJVgKGBQ+B4eI8CGo9ALkZuZpYEhE66TQEAiUMU2kjIhjkh
OeE5yOAWGQ71KiBvWQuC06r88eB+AQs=
=Qgm5
-----END PGP SIGNATURE-----

--RASg3xLB4tUQ4RcS--