Subject: Re: [RFC V3 1/2] mac80211: add hw 80211 encapsulation offloading
 support
To:     =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org,
        Shashidhar Lakkavalli <slakkavalli@datto.com>,
        Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
References: <20190401131416.22646-1-john@phrozen.org>
 <20190401131416.22646-2-john@phrozen.org> <87k1gcpwgy.fsf@toke.dk>
 <5647fa751aed450f09312c35f8d5becd47e26b66.camel@sipsolutions.net>
 <878swspmdu.fsf@toke.dk>
From:   John Crispin <john@phrozen.org>
Message-ID: <386f1922-93e7-f962-a3e3-e160ca57176a@phrozen.org>
Date:   Tue, 2 Apr 2019 16:37:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <878swspmdu.fsf@toke.dk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 02/04/2019 15:28, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
>> On Tue, 2019-04-02 at 11:50 +0200, Toke Høiland-Jørgensen wrote:
>>
>> [snip, you really should try that sometimes ;-)]
>>
>>> ieee80211_queue_skb() calls ieee80211_get_txq() which treats skb-
>>> datalike it contains an 802.11 header. That is probably not the
>>> intention here, is it?
>> Indeed, that makes no sense.
>>
>>> I guess we could augment the TXQ stuctures to also handle 802.3 frames
>>> (and introduce ieee80211_queue_skb_8023())? Or would it be better to
>>> have a qdisc on 802.3-mode interfaces and push packets back to that? I
>>> guess we'd still benefit from per-station queueing of packets even if
>>> they are Ethernet frames, which would mean amending the TXQs would be
>>> better?
>> TXQs would be better, yes. We should do that.
> Cool. Glad that we agree ;)
>
> -Toke

Hi Toke,

will add that for V4, thanks

     John