Subject: Re: [PATCH 0/6] stricter netlink validation
To:     David Miller <davem@davemloft.net>, johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        pablo@netfilter.org
References: <20190404065408.5864-1-johannes@sipsolutions.net>
 <20190404.102850.631122626573856353.davem@davemloft.net>
From:   David Ahern <dsa@cumulusnetworks.com>
Message-ID: <db599b6b-94a5-3123-5613-9e349fcee702@cumulusnetworks.com>
Date:   Thu, 4 Apr 2019 20:44:25 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190404.102850.631122626573856353.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 4/4/19 11:28 AM, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Thu,  4 Apr 2019 08:54:02 +0200
> 
>> Here's a version that has passed build testing ;-)
> 
> :-)
> 
> I really like the approach taken here, and done in such a way that
> new attributes added get strict checking by default.
> 
> I'll let David Ahern et al. have time to review this.
> 

Hit a compile issue right out of the gate:

$ make O=kbuild/perf -j 24 -s
/home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c: In function
‘validate_and_copy_check_pkt_len’:
/home/dsa/kernel-2.git/net/openvswitch/flow_netlink.c:2887:8: error:
implicit declaration of function ‘nla_parse_deprecated_strict’
[-Werror=implicit-function-declaration]
  err = nla_parse_deprecated_strict(a, OVS_CHECK_PKT_LEN_ATTR_MAX,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~

You should do an allmodconfig build to check for any others. I disabled
ovs to continue.