Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09036C282DC for ; Sat, 6 Apr 2019 08:45:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D41D3218C3 for ; Sat, 6 Apr 2019 08:45:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726436AbfDFIpu (ORCPT ); Sat, 6 Apr 2019 04:45:50 -0400 Received: from www.osadl.org ([62.245.132.105]:59192 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbfDFIpu (ORCPT ); Sat, 6 Apr 2019 04:45:50 -0400 X-Greylist: delayed 673 seconds by postgrey-1.27 at vger.kernel.org; Sat, 06 Apr 2019 04:45:49 EDT Received: from debian01.hofrr.at (178.115.242.59.static.drei.at [178.115.242.59]) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id x368jbQJ008629; Sat, 6 Apr 2019 10:45:37 +0200 From: Nicholas Mc Guire To: Adham Abozaeid Cc: Ajay Singh , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH V2] staging: wilc1000: drop explicit conversion to bool Date: Sat, 6 Apr 2019 10:40:30 +0200 Message-Id: <1554540030-12740-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org As the expression evaluates to a boolean anyway (relational and logical operators) conversion with the ternary operator is not needed here as coccinelle notes (boolconv.cocci) Signed-off-by: Nicholas Mc Guire --- V2: sent out the wrong version - the commit message was longer than 75 chars - only change here is the commit message wrapping. scripts/coccinelle/misc/boolconv.cocci warned about: drivers/staging/wilc1000/wilc_wlan.c:14:48-53: WARNING: conversion to bool not needed here Patch was compile tested with: x86_64_defconfig + Staging=y, WILC1000_SDIO=m, WILC1000_SPI=m, WILC1000=m (checkpatch, sparse and cocci clean otherwise) Patch is against 5.1-rc3 (localversion-next is -next-20190403) drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index c238969..6c9fd3a 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c @@ -11,7 +11,7 @@ static inline bool is_wilc1000(u32 id) { - return ((id & 0xfffff000) == 0x100000 ? true : false); + return ((id & 0xfffff000) == 0x100000); } static inline void acquire_bus(struct wilc *wilc, enum bus_acquire acquire) -- 2.1.4