Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58EBFC10F0E for ; Mon, 15 Apr 2019 11:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3021F2073F for ; Mon, 15 Apr 2019 11:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727353AbfDOLSL (ORCPT ); Mon, 15 Apr 2019 07:18:11 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:36788 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726042AbfDOLSK (ORCPT ); Mon, 15 Apr 2019 07:18:10 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hFzcn-0005zq-PA; Mon, 15 Apr 2019 13:18:09 +0200 Message-ID: <31315303489707b1a007e0def43f0db0295a0be1.camel@sipsolutions.net> Subject: Re: [PATCHv3 2/2] mac80211: Implement API to configure station specific rssi threshold From: Johannes Berg To: Tamizh chelvam Cc: linux-wireless@vger.kernel.org Date: Mon, 15 Apr 2019 13:18:08 +0200 In-Reply-To: <1554831488-27065-3-git-send-email-tamizhr@codeaurora.org> (sfid-20190409_193850_575303_37736D70) References: <1554831488-27065-1-git-send-email-tamizhr@codeaurora.org> <1554831488-27065-3-git-send-email-tamizhr@codeaurora.org> (sfid-20190409_193850_575303_37736D70) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > + if (sta->rssi_config) { > + old_rssi_config = sta->rssi_config; > + RCU_INIT_POINTER(sta->rssi_config, NULL); Looks like you need an __rcu annotation somewhere to make this compile sparse-warnings-free. johannes