Message-ID: <dd9897b2800d68e241b63996e964cc94bde0db51.camel@sipsolutions.net>
Subject: Re: [PATCH 1/2] wireless: Support auth-at-ms timer in sta-info
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ben Greear <greearb@candelatech.com>,
        linux-wireless@vger.kernel.org
Date:   Mon, 15 Apr 2019 19:03:12 +0200
In-Reply-To: <a8865096-f19e-608f-13c2-08036876d316@candelatech.com>
References: <20190412213710.17292-1-greearb@candelatech.com>
         <cf95c43bcfe1bd4d8fbc8aca8ecc65dac9eeae0c.camel@sipsolutions.net>
         <a8865096-f19e-608f-13c2-08036876d316@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-04-15 at 09:32 -0700, Ben Greear wrote:
> On 4/15/19 4:15 AM, Johannes Berg wrote:
> > On Fri, 2019-04-12 at 14:37 -0700, greearb@candelatech.com wrote:
> > > From: Ben Greear <greearb@candelatech.com>
> > > 
> > > Report time stamp of when sta became authenticated.
> > 
> > You didn't actually implement this ;-)
> > 
> > Did you mean associated?
> > 
> > > + * @auth_at_ms: time in ms of the last assoc -> auth transition.
> > 
> > There's commonly not really such a transition?
> 
> Oh, I guess AUTHORIZED is only when doing .1x authentication?  My test case
> was (luckly?) doing that, so I didn't notice the bug.

Oh, you meant *authorized*... Most of the code uses "auth" ==
"authenticated" :-)

johannes