Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1363C282DA for ; Tue, 16 Apr 2019 13:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74D342077C for ; Tue, 16 Apr 2019 13:14:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729360AbfDPNOH (ORCPT ); Tue, 16 Apr 2019 09:14:07 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:54306 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727841AbfDPNOF (ORCPT ); Tue, 16 Apr 2019 09:14:05 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hGNuL-0007qZ-NG; Tue, 16 Apr 2019 21:13:53 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hGNuE-0000CE-GM; Tue, 16 Apr 2019 21:13:46 +0800 Date: Tue, 16 Apr 2019 21:13:46 +0800 From: Herbert Xu To: Johannes Berg Cc: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Arend Van Spriel , Felix Fietkau , linux-wireless@vger.kernel.org, Eric Dumazet , netdev@vger.kernel.org Subject: Re: [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues Message-ID: <20190416131346.u2uolljlrd5t2jro@gondor.apana.org.au> References: <87sgvmvg9g.fsf@toke.dk> <773e4dff-29fd-22b4-e4bc-cd5a94c66dc2@broadcom.com> <20190416074444.pdubbh6fbibdnhi7@gondor.apana.org.au> <73b18131-2777-da5c-a6ee-9d9b3e13cd06@broadcom.com> <20190416083636.5ttvezqyhzr2worg@gondor.apana.org.au> <87ef62uwfm.fsf@toke.dk> <95f86cf69dee05a176625925657cf0df0e97b5c9.camel@sipsolutions.net> <20190416093707.dtlwcmitzqopaeaw@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Apr 16, 2019 at 11:39:56AM +0200, Johannes Berg wrote: > > > not to mention > > breaking certain applications that rely on congestion feedback? > > This I don't understand. The congestion feedback happens through socket > buffer space etc. which is still there (as long as nobody sneaks in an > skb_orphan() call) The congestion control happens at two levels. You are right that the socket buffer acts as one limit. However, other applications may also rely on the TX queue being full as the throttle (by setting a sufficiently large socket buffer size). Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt