Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC1CC10F14 for ; Wed, 17 Apr 2019 02:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14C6520821 for ; Wed, 17 Apr 2019 02:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728958AbfDQCNv (ORCPT ); Tue, 16 Apr 2019 22:13:51 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:51190 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728108AbfDQCNu (ORCPT ); Tue, 16 Apr 2019 22:13:50 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hGa51-0005Rp-IS; Wed, 17 Apr 2019 10:13:43 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hGa51-00011Y-EO; Wed, 17 Apr 2019 10:13:43 +0800 Date: Wed, 17 Apr 2019 10:13:43 +0800 From: Herbert Xu To: Johannes Berg Cc: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Arend Van Spriel , Felix Fietkau , linux-wireless@vger.kernel.org, Eric Dumazet , netdev@vger.kernel.org Subject: Re: [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues Message-ID: <20190417021343.jysv3s7wed6em4ug@gondor.apana.org.au> References: <20190416074444.pdubbh6fbibdnhi7@gondor.apana.org.au> <73b18131-2777-da5c-a6ee-9d9b3e13cd06@broadcom.com> <20190416083636.5ttvezqyhzr2worg@gondor.apana.org.au> <87ef62uwfm.fsf@toke.dk> <95f86cf69dee05a176625925657cf0df0e97b5c9.camel@sipsolutions.net> <20190416093707.dtlwcmitzqopaeaw@gondor.apana.org.au> <20190416131346.u2uolljlrd5t2jro@gondor.apana.org.au> <8678e1a4eb816878867f71878e8fe7c225f1b7f7.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8678e1a4eb816878867f71878e8fe7c225f1b7f7.camel@sipsolutions.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Apr 16, 2019 at 09:13:16PM +0200, Johannes Berg wrote: > > I'm not sure how they'd even realize this, other than packets getting > dropped? Which of course we do here as well, we didn't invent something > that let's us expand memory arbitrarily ;-) They rely on the queueing mechanism providing feedback via an error return value when the queue becomes full. From my cursory look at net/mac80211 you seem to be always returning success in ieee80211_subif_start_xmit. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt