DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F05796019D
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     Brian Norris <briannorris@chromium.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips
References: <1552450443-351-1-git-send-email-yhchuang@realtek.com>
        <20190325143611.sjwwjqtrftxntwyk@penguin>
        <20190326075414.GA8598@redhat.com>
        <CA+ASDXNcCNcBmiHi468p1foWgSOXy9Mt8o+CD17Bd4PqhUXFoA@mail.gmail.com>
        <F7CD281DE3E379468C6D07993EA72F84D17CB940@RTITMBSVM04.realtek.com.tw>
        <20190327102623.GA20943@redhat.com>
        <F7CD281DE3E379468C6D07993EA72F84D17D50A4@RTITMBSVM04.realtek.com.tw>
        <87zhp0g2a5.fsf@codeaurora.org>
        <F7CD281DE3E379468C6D07993EA72F84D17D6AD6@RTITMBSVM04.realtek.com.tw>
Date:   Thu, 18 Apr 2019 16:55:44 +0300
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D17D6AD6@RTITMBSVM04.realtek.com.tw>
        (Tony Chuang's message of "Tue, 9 Apr 2019 10:12:16 +0000")
Message-ID: <87ftqf2za7.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Tony Chuang <yhchuang@realtek.com> writes:

>> From: Kalle Valo [mailto:kvalo@codeaurora.org]
>> Sent: Monday, April 08, 2019 7:33 PM
>> To: Tony Chuang
>> Cc: Brian Norris; Johannes Berg; linux-wireless; Greg Kroah-Hartman; Pkshih;
>> Andy Huang; Larry Finger; Stanislaw Gruszka
>> Subject: Re: [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac
>> wireless network chips
>> 
>> Tony Chuang <yhchuang@realtek.com> writes:
>> 
>> > Hi Kalle
>> >
>> >> From: Stanislaw Gruszka [mailto:sgruszka@redhat.com]
>> >> Sent: Wednesday, March 27, 2019 6:26 PM
>> >> To: Tony Chuang
>> >> Cc: Brian Norris; Kalle Valo; Johannes Berg; linux-wireless; Greg
>> Kroah-Hartman;
>> >> Pkshih; Andy Huang; Larry Finger
>> >> Subject: Re: [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac
>> >> wireless network chips
>> >>
>> >
>> > It's just a gentle reply to ask if rtw88 is getting merged.
>> > Are you still reviewing or is there anything I can help.
>> 
>> I just have been busy with other stuff, sorry. I'll try find time for
>> this soon.
>> 
>
> It's OK. If you need any help just let me know. :)

Sorry, still haven't been able to review the driver. But something what
I found strange was "default y" in Kconfig, is that really necessary?

> BTW, I want to change the license from GPL to Dual BSD/GPL.
> Would you want to change them in the initial patch set, or I send a separate
> one after it got merged?

Please submit a new version with the new license. But don't any other
changes than change the license and possibly remove the default line in
Kconfig.

-- 
Kalle Valo