Message-ID: <16b5551f8850370e50cffc7b6cd88963b8fd739c.camel@sipsolutions.net>
Subject: Re: [PATCH 2/2] mac80211_hwsim:  Update feature flags
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Alexander Wetzel <alexander@wetzel-home.de>
Cc:     linux-wireless@vger.kernel.org
Date:   Tue, 23 Apr 2019 12:18:13 +0200
In-Reply-To: <20190422213412.16533-2-alexander@wetzel-home.de>
References: <20190422213412.16533-1-alexander@wetzel-home.de>
         <20190422213412.16533-2-alexander@wetzel-home.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-04-22 at 23:34 +0200, Alexander Wetzel wrote:
> Hwsim is not using HW crypto offload and can correctly rekey PTK keys.
> Set NL80211_EXT_FEATURE_CAN_REPLACE_PTK0 to not trigger workarounds.

Why not do this generally also in mac80211 when only software crypto is
possible?

> Also allow Extended Key ID to be used with hwsim, regardless that the
> driver A-MPDU aggregation is violating IEEE 802.11 and can aggregate
> MPDUs using different key IDs into one A-MPDU.
> 
> Hwsim can only communicate with other hwsim cards and itself is able to
> handle the non-standard A-MPDUs on Rx.

Makes sense, but a comment would be nice.

Actually though, hwsim never even builds aggregates :-) It negotiates
sessions, but doesn't really make A-MPDUs.

johannes