Subject: Re: [PATCH] brcmfmac: remove the duplicate line of sending mail box
 interrupt
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
To:     Wright Feng <Wright.Feng@cypress.com>, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, kvalo@codeaurora.org,
        Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
References: <1555901236-145920-1-git-send-email-wright.feng@cypress.com>
 <16a4dcd3418.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Message-ID: <164b59e8-633b-84cc-179f-9bdd7ec696a7@broadcom.com>
Date:   Wed, 24 Apr 2019 10:46:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <16a4dcd3418.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 4/24/2019 7:24 AM, Arend Van Spriel wrote:
> On April 22, 2019 4:47:31 AM Wright Feng <Wright.Feng@cypress.com> wrote:
> 
>> The line is duplicate so remove it from pcie.c. We don't need to send
>> host to dongle mail box interrupt twice after writing data.
> 
> Hi Wright,
> 
> Thanks for the patch. I am a bit early as it is not uncommon that 
> hardware requires an extra kick. Might be the case here for some chips. 
> Will follow-up on it.

Hi Wright,

I checked in our dhd driver code and it also does a double write. Turns 
out to be a hardware workaround so we need to keep this. It is worth a 
comment though.

Thanks,
Arend