Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1577302yba; Thu, 25 Apr 2019 02:04:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyN1fmIrn++ZmA/81QkK4WticBMyWsk2jGZP80XJdYDivznuOY2knfa7Cs47IHTpKGGlMip X-Received: by 2002:a17:902:6bc2:: with SMTP id m2mr37854725plt.194.1556183095535; Thu, 25 Apr 2019 02:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556183095; cv=none; d=google.com; s=arc-20160816; b=GJ6ZNN1PvzleqGEkMj61BNGxPhhj2g0hX6wf6CcXOlSi5Pv2Ws5mdedEdfS5rWakqc x/D9pwJ0mx76cmPzxB6FLrCAIgit1JHQlJ09ImmPmQwpbUuARcDP+wTtm8cL738m0Y2h JsxZHzXWfVUuCZkjsU9QeB6cRCeTfeCNAMfQxKqtlsPkhRLrgjSJQzB+stJTsnBniLoN UZhfL/YqY/6MZzWLuRgckg/HTKmZsTufb5gThWUDGmLjRNc6biDfxJnAlMcLQX5Q1CsL FWe8/wuB9xH0MsJ2rDlOdAO+c0du1amyxq3LE2XX9mI8yQYCMvM2K716FQV6d10RRCwJ dZ4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=nadmt9LKHeLAlZGjvlEYobYVgeYpW5lzRhsOskRjr3M=; b=un8W84hQkjbv9nuTY4LUJfnNG9HLQ8VFyP6Iw0EpKh/dzWZ9vRGLhBzwQhdkbTMHqz k51TWaXS5TDx9QunxpbGquKEWVwUtUhEvki99GdOONxRxhBhrtkf/SsRMIqjLyA10/e1 NzEfa1GI8siGKNHxrhfrjN7lIqUhkLDTx92DHbC+iAqtv1GWEcoJp0WJASp5KmZaxWSY IMwyoUD9AlkNvX8CalJ0AqqONMxihM908OaYcghSJI83n+J94y/hGKArCgo1pj/2wQJH kIWApFAe8dkK/dCWx7ip5a3X/c6nxM6g3K23bBoG44gPMo5QKapTTHpcefA90nANUE2Y 73YA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si20114456pgv.589.2019.04.25.02.04.38; Thu, 25 Apr 2019 02:04:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727201AbfDYIon (ORCPT + 99 others); Thu, 25 Apr 2019 04:44:43 -0400 Received: from [5.180.42.13] ([5.180.42.13]:52664 "EHLO deadmen.hmeau.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1725965AbfDYIon (ORCPT ); Thu, 25 Apr 2019 04:44:43 -0400 X-Greylist: delayed 509 seconds by postgrey-1.27 at vger.kernel.org; Thu, 25 Apr 2019 04:44:43 EDT Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hJZzb-0003JA-Io; Thu, 25 Apr 2019 16:44:31 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hJZzY-0002EU-MH; Thu, 25 Apr 2019 16:44:28 +0800 Date: Thu, 25 Apr 2019 16:44:28 +0800 From: Herbert Xu To: Johannes Berg Cc: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Arend Van Spriel , Felix Fietkau , linux-wireless@vger.kernel.org, Eric Dumazet , netdev@vger.kernel.org Subject: Re: [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues Message-ID: <20190425084428.poni4y7mqox5up5t@gondor.apana.org.au> References: <95f86cf69dee05a176625925657cf0df0e97b5c9.camel@sipsolutions.net> <20190416093707.dtlwcmitzqopaeaw@gondor.apana.org.au> <20190416131346.u2uolljlrd5t2jro@gondor.apana.org.au> <87wojut7f7.fsf@toke.dk> <20190417033834.ep6t7r6ttvjek5g7@gondor.apana.org.au> <87tvexrnxm.fsf@toke.dk> <99da695257304d32b65e2db8b7ada06759087c90.camel@sipsolutions.net> <20190425083558.p3kqodaawr2jcfhr@gondor.apana.org.au> <0190c32f3d861d9d7a783090653645c5ae3a7fa3.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0190c32f3d861d9d7a783090653645c5ae3a7fa3.camel@sipsolutions.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Apr 25, 2019 at 10:39:52AM +0200, Johannes Berg wrote: > > Yes, that's what I meant, it can only ever return NET_XMIT_SUCCESS or > NET_XMIT_CN. This will not trigger the code you mentioned before though. You are right that it does not. However, the fact that this congestion indication is lost is a bug rather than a feature. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt