Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2046196yba; Thu, 25 Apr 2019 09:45:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZbgBOYxYbYO/xKPrvHN1Zj5dpRuxcDXGx2EQ/md8W679xt2MU+aRFiq5eg0VU9jtiE07X X-Received: by 2002:a63:79cf:: with SMTP id u198mr24144852pgc.34.1556210717141; Thu, 25 Apr 2019 09:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556210717; cv=none; d=google.com; s=arc-20160816; b=vDk6YSeqXoef6Mw4PLjTx8UGQlFp0oqjUhSyENinLUosDVRZH2NLr17x3i6Nkrm0Aa WTO/GGdq/b0YDZxrl+aj6Gw+E/AR0R5S3Ys85RQKQDuWcIGaPMdTXB8nvPWLd4N7IyQn 09ReRq52GfEKcY5WbOr5Gj/TNsktP8pIIMFy1i8kxDH347CqfNofNlks+tPYCyQN5BLF 2hNyPEC5/iI+6+6CTl2Z0KHEUPbOevg1/NofelrcSvZ6o2iRTGDpLZBjdbCjwHUX+jG/ VOjjNW35qNAZHwJoWA02K+K9etX3dpehVkGxL46MLgPY2i9msCZPFELCXGI4GfrqEBGm s0Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=/nVFEFFT5Wy8bdtUpzK2CLvaDmn53Xn2Ic07wLri7/M=; b=nTs9QIuecoMCEUpmmoZXJ+CAMD2+eeReGksOv4NlKmAnNVH1XDUOg6IdkyyGtVYfi/ biHiDQYzjwJA79xthPKtm4IxBnNDwJvHyBCi11tzSgfBh2IWA+fNmM/HGKNUvO+Jfm2v t0Aqt/AVlLMTvD1HNjIgFxCbN0hTKnE9DqfUj0D1Aiube0qj3AEfNvCMPKfwOfSJ2EeC Lk7pjtBy4nlux5xkcAkdNXUxvqIYyLoOiOi0wTaFSJ8HV/VU/G1oq/l85tnRsDimvYcp vzaZwpODDGjFpsewYv9xmhK7SVXfkGWAIk1yeG1VGNkkFNuFUp+pb82HLrp37FIuZAwm an6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=b1RIx+Mo; dkim=pass header.i=@codeaurora.org header.s=default header.b=P6HE5NAT; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si3306603pgg.114.2019.04.25.09.45.02; Thu, 25 Apr 2019 09:45:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=b1RIx+Mo; dkim=pass header.i=@codeaurora.org header.s=default header.b=P6HE5NAT; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbfDYQmp (ORCPT + 99 others); Thu, 25 Apr 2019 12:42:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55176 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfDYQmp (ORCPT ); Thu, 25 Apr 2019 12:42:45 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D29266077A; Thu, 25 Apr 2019 16:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556210564; bh=dDlU680sfNkZ6mFUB0/9to0eOLdv1q/WmS0YAu/rZCg=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=b1RIx+Moj81fnMgD7VaZwznpQkXHNbbngxxaPERclu46BXz6bJR3fIFwIZ9wgshkC NhkLtcoH1VLiULdF5cAXbQ7wPobBHHJf5gujYFgyIqkv0gOu8J+bqi62aWl9bmi3yu Z6iZMTTXKLr0P4Y70LyUC76ip+bVIjM9ryrEI3ZM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 987AF6034D; Thu, 25 Apr 2019 16:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556210564; bh=dDlU680sfNkZ6mFUB0/9to0eOLdv1q/WmS0YAu/rZCg=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=P6HE5NATeLx715tOwdK1RpFHfrvMZNz2qfm2xNE2bFhvSV8LAbjUyV1zF7sH9L8Xo G3M1qunAgq13/wp6edP2GbFaIR/waMl3uCzJqDTu0jKLeYvK1so5syJL4tbGyqrzDI svhMVGnATDbFZEDVccTp6LDJZ65ptG6h0YBeolxM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 987AF6034D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rsi: Fix NULL pointer dereference in kmalloc From: Kalle Valo In-Reply-To: <20190323204916.8368-1-pakki001@umn.edu> References: <20190323204916.8368-1-pakki001@umn.edu> To: Aditya Pakki Cc: pakki001@umn.edu, kjlu@umn.edu, Amitkumar Karwar , Siva Rebbagondla , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190425164244.D29266077A@smtp.codeaurora.org> Date: Thu, 25 Apr 2019 16:42:44 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Aditya Pakki wrote: > kmalloc can fail in rsi_register_rates_channels but memcpy still attempts > to write to channels. The patch replaces these calls with kmemdup and > passes the error upstream. > > Signed-off-by: Aditya Pakki Patch applied to wireless-drivers-next.git, thanks. d5414c2355b2 rsi: Fix NULL pointer dereference in kmalloc -- https://patchwork.kernel.org/patch/10866983/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches