Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCHv2] ath10k: Add wrapper function to ath10k debug
To:     Venkateswara Naralasetty <vnaralas@qti.qualcomm.com>,
        Venkateswara Naralasetty <vnaralas@codeaurora.org>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc:     Kan Yan <kyan@chromium.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <1556283505-29539-1-git-send-email-vnaralas@codeaurora.org>
 <b9f263a4-e9da-18bb-5932-941a018ee860@candelatech.com>
 <be151755e771423eaa0ad6e6e2e81c2b@APSANEXR01F.ap.qualcomm.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <380a88cf-9da4-a772-a119-d8df24d5b450@candelatech.com>
Date:   Fri, 26 Apr 2019 06:57:10 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <be151755e771423eaa0ad6e6e2e81c2b@APSANEXR01F.ap.qualcomm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 4/26/19 6:38 AM, Venkateswara Naralasetty wrote:

>>>    #ifdef CONFIG_ATH10K_DEBUG
>>> -void ath10k_dbg(struct ath10k *ar, enum ath10k_debug_mask mask,
>>> -		const char *fmt, ...)
>>> +void __ath10k_dbg(struct ath10k *ar, enum ath10k_debug_mask mask,
>>> +		  const char *fmt, ...)
>>>    {
>>>    	struct va_format vaf;
>>>    	va_list args;
>>
>> Do you still need the check later in this method:
>>
>> if (ath10k_debug_mask & mask)
>>
>> since you already checked in the ath10k_dbg() macro?
> Yes, we need this check.
> Otherwise all debug messages will be printed even without any debug mask set in case of tracing enabled.

Ahh, I see.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com