Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp793283yba; Fri, 26 Apr 2019 08:50:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqystNrdrB13NmVCpBbEH8LtaEeO69Y32uCnT1OzAd9VatoFwVrqB1Mmv33tLU06ka5IwgIS X-Received: by 2002:a62:388d:: with SMTP id f135mr48198518pfa.103.1556293837872; Fri, 26 Apr 2019 08:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556293837; cv=none; d=google.com; s=arc-20160816; b=ZCoF5diyhahZlXiSjNxWae3t+WHO3KkBV+wKq4mDdQCelKd2N790VhGJgTXjQsH8bd IGtxRWWFoUaKOzie0bm6EAIaO42x775SKXmuhcokRbgBf5GGF1bH9VJzRWQ++OWe6oOn 5rQ2rVNJU/d72KcLSjWJTWsGxtKlk8MJV5stVmvaOarLG6aqPjsaERyjXdEkrAVBuCkt CnqBnsqL80IEZHW4REs90R01G5Zgrqdssk2NFKP3BERxNGbF+CLzA7esqKPBRcZKmnoG xf27hza1x9ta+shKu08aD+w6QRUkvt3v82+bwUVa42frnGr7nQaXCx55DY7J6EtwBwQ8 A84w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=1SenC8qJho56Ly37FgXoHVpNodC/2YwpkK5cj8gYVHY=; b=yWxyGsQZcnoSlPruZ3+404iWgrgBp47B8PLeliwginYTj2Q/qbTUm4b9dANgvUlo/y UcmFiM3+sRoqnVysCafkl7LrhyI0rXxnNLmRIJEkckFEkaLiWZu2o1liCa70DGhB4p/f Z3cGRXL3344BOsquSqPWuujlEJ5BynTaYZ6kgW/I+9Slh4dq9UbwiVAz6ppwlK8CDjFj z58o1Eulzpmdr9kXyslu5ItTthYirsTMI5d5Vmd1dind/sAkTA47IqbVPbPNCyQfR59e ZlnLa3ypV3XrPN+0cho4JWD0+qCqRMn23dJRBbLtdWQhUChcCQKN24g9Egtjxf7cenb9 Ethg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u25si12500408pgk.595.2019.04.26.08.50.23; Fri, 26 Apr 2019 08:50:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfDZPuA (ORCPT + 99 others); Fri, 26 Apr 2019 11:50:00 -0400 Received: from alexa-out-ams-02.qualcomm.com ([185.23.61.163]:21644 "EHLO alexa-out-ams-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbfDZPt7 (ORCPT ); Fri, 26 Apr 2019 11:49:59 -0400 X-IronPort-AV: E=Sophos;i="5.60,398,1549926000"; d="scan'208";a="2367517" Received: from ironmsg01-ams.qualcomm.com ([10.251.56.2]) by alexa-out-ams-02.qualcomm.com with ESMTP; 26 Apr 2019 17:43:41 +0200 X-IronPort-AV: E=McAfee;i="5900,7806,9238"; a="7889765" Received: from lx-merez1.mea.qualcomm.com ([10.18.173.103]) by ironmsg01-ams.qualcomm.com with ESMTP; 26 Apr 2019 17:43:41 +0200 From: Maya Erez To: Kalle Valo Cc: Alexei Avshalom Lazar , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, Maya Erez Subject: [PATCH 2/9] wil6210: fix _desc access in __wil_tx_vring_tso Date: Fri, 26 Apr 2019 18:43:30 +0300 Message-Id: <1556293417-27097-3-git-send-email-merez@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1556293417-27097-1-git-send-email-merez@codeaurora.org> References: <1556293417-27097-1-git-send-email-merez@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Alexei Avshalom Lazar _desc is defined in __wil_tx_vring_tso() and may not be set in case len is 0, verify _desc is set. Signed-off-by: Alexei Avshalom Lazar Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/txrx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c index 4ccfd14..a8f315b 100644 --- a/drivers/net/wireless/ath/wil6210/txrx.c +++ b/drivers/net/wireless/ath/wil6210/txrx.c @@ -1760,6 +1760,9 @@ static int __wil_tx_vring_tso(struct wil6210_priv *wil, struct wil6210_vif *vif, } } + if (!_desc) + goto mem_error; + /* first descriptor may also be the last. * in this case d pointer is invalid */ -- 1.9.1