Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3744464yba; Mon, 29 Apr 2019 07:51:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFgtd5wTeEBWb6XoEGgjuV0nXRYdNA7KTlqcNEbv62ADeK3Lty+e/Pt9jjCRC9aJJ10rnh X-Received: by 2002:a63:8dc8:: with SMTP id z191mr23491331pgd.9.1556549495076; Mon, 29 Apr 2019 07:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556549495; cv=none; d=google.com; s=arc-20160816; b=HTOaNjKnqI8N4dtZARywoSiAX0nBbTs9cVyahrtG+V/DJVUbAp/umOFclDeeqj9B/r pquID4wiv43xpsQ37CO0wUFzih4LpXOOdOmtLmPO3rtaXglmdQvdjSRZE86d25dsdXCj rispXWP91sM2+/jZnWGGbt3yFv1i9hpPFRmUnkWuGDSWxqa1vFbAjEaFrsHUYEYQMcQq DtgjvGUWuDF/igSor5A1q5A4QG0CcTuYtZVcKKrzDIwkGdJZ9OS+S3q36On0yEIDtgoq ImoSmoyBbuXhxZaO/o4VYR7ehWmLCSD9Jngw0kFAStX+MjORM40uDZuj8dpJMdiQUFyw YLdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=5MpWMtzxOxFWnl/Wy90Y2DJMyPq3bMO2WlsNKzdyxbY=; b=MFI/eNqIHpwimwJ4ZBtBcji0Ta4dBwEUlR3J9RQ9Pz0kJmgGQmKTmnl4lmHxIBIGIM TVD411W5P062YzGYfY0uKv8L0t7g0u+XWPjbrHMR8TU6HZrRRk9FI+Pod5HgQqoHfR/C bB/dR+uyZ63DgUagTDta4pC4rPFuCRHmS6vxhnu4RzpR23evyraVBvuLDVh6UWoU0G1J pvO13Lnm+SlssT5NWBo+FpH5P8iJlEinJlzuAaMe/R1BPWF8FYhYjK5ac8xILuQIdVHt qwL8jyFshLSM0pwrzO4l0eJRl+uwxc5ARQRWCqM3pO/bnYZW7Kt0g3HoXxyBYUd8n9EF Shtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ah5nNChg; dkim=pass header.i=@codeaurora.org header.s=default header.b=eqFUYsKY; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si19852552pgo.81.2019.04.29.07.51.20; Mon, 29 Apr 2019 07:51:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ah5nNChg; dkim=pass header.i=@codeaurora.org header.s=default header.b=eqFUYsKY; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728409AbfD2Ouk (ORCPT + 99 others); Mon, 29 Apr 2019 10:50:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42016 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728350AbfD2Ouj (ORCPT ); Mon, 29 Apr 2019 10:50:39 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3C462605A2; Mon, 29 Apr 2019 14:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556549439; bh=Med0BVNCDB0qzfpASZ4nce6f8HqonA2tKuVNkYHuYQI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Ah5nNChgvOOw6mOmFgT7PL5tXnN5pdBdG8kBIovG6ogqF8qbt5KsONyyvZkLpNIjB iHA5ZelqrKgwdeoAq1WjsWY1uy7C6x7mOROm+Nl2EMGKIIgilQgFUF5X4HfHK5XD86 Pp1cZMfjQaEqBwWVBT0/ZyO1POKTO3k9qaBrZKY0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6E88060214; Mon, 29 Apr 2019 14:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556549438; bh=Med0BVNCDB0qzfpASZ4nce6f8HqonA2tKuVNkYHuYQI=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=eqFUYsKYQ/rCJUcCjTjobW0O2VTsNvQOhxsfHu/6Vez8QwUFRBnH2SFAdOuS/hTka 078kCQE1N3wui2PpI8xCGaKM64GRqIyWR4Z7C7brfagSNkF0X27Q+RnnMzJET9Fi0g 85S8YUEwaylKD48uLyOKMcmKhJgH1fTa5g5PbpL8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6E88060214 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath6kl: remove redundant check of status != 0 From: Kalle Valo In-Reply-To: <20190404134723.24667-1-colin.king@canonical.com> References: <20190404134723.24667-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190429145039.3C462605A2@smtp.codeaurora.org> Date: Mon, 29 Apr 2019 14:50:39 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > The check on status not being zero is redundant as previous code > paths that set status to an error value break out of the while > loop and hence status is never non-zero at the check. Remove > this redundant code. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King > Reviewed-by: Mukesh Ojha > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e643da21e19a ath6kl: remove redundant check of status != 0 -- https://patchwork.kernel.org/patch/10885625/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches