Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3746072yba; Mon, 29 Apr 2019 07:53:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWUKsX9o2py+qzUKAAV//qK/yq6sozBticg6Ff12CqmHnR8FbO7oZFTPkVL8wEuG11IPA5 X-Received: by 2002:a63:6fcf:: with SMTP id k198mr58402156pgc.158.1556549600996; Mon, 29 Apr 2019 07:53:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556549600; cv=none; d=google.com; s=arc-20160816; b=nUUYlK/Ey/DPoLjJw8DfQgIR32HqnjbAQB4P7SWGGo+h/3LVHEDon/4zV7zC5YhiqU +ye/hkoneiz6OW5503iIwrhsUK1jyKrIoiDVb0GIZcP1/nACiTs/unhQt8FBEeZ6vTGq OMU7P3f8WRgKXWLv6KSMVghXfHw48uGcIi9afKtrw3FEguvby2OjQdRUc2Df6W0Ggg98 nK11yLOq/TctmeKuhFM/xW0cTP0EZL4YkQLU+buNnX5N4VDaK6qLoTQP4qq9D7t4Cyy4 IXlPoGhXRulA/plHQOp+k7PWRgajpHYhPBSAKXcusmp8A3KpOCDNFAUIao0UvXLcL4Xw UCLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=jqCTuaEq7JYAnS8sJvdjFpGd2RTkvyE5D4AbcYLnNNc=; b=boWaqxX+2V3nwFt+OU9y04ewxQ+o8xMd90ZSzpIdvDaV/7/QlxpaX4oWpJ1ctM++CR 6H7BPsee8/UijDEwaLHNoXz0EgBPQ3wn234wX/i8r5Goy11zVsq/mBSfjRpVDOdo5IOk J7UNutKScuLtRbd5O5+M0eVUfw3qQJ2fE8koNnj60dle9XmEsO2i8uln2B1qQ9yWg2hg jWkIBJ939jxXuGf9gfHCX2mYZDe6jWCVGBSAXLnt5iusJA3v4K1ymS07KPJtmgGR5GVd VHAUn8n9FUyaUWfFViYUSx/7OuHDfSVQ64VSi8CjbGAUq6QiZPjRF1HSt0v5KWYKb9pC HjuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=kYg68XXh; dkim=pass header.i=@codeaurora.org header.s=default header.b=AahlZjU1; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12si34502927pla.112.2019.04.29.07.53.06; Mon, 29 Apr 2019 07:53:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=kYg68XXh; dkim=pass header.i=@codeaurora.org header.s=default header.b=AahlZjU1; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728535AbfD2Owi (ORCPT + 99 others); Mon, 29 Apr 2019 10:52:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45004 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728339AbfD2Owi (ORCPT ); Mon, 29 Apr 2019 10:52:38 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D162E60E41; Mon, 29 Apr 2019 14:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556549557; bh=Wjq2h5vre5y0bW0Mr5l5Eu4XzsvQkhOSmyWFDH05/FU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=kYg68XXha727rDxtd5IdOppPors0vlewjmaPwbohlATg9DPqBv9qJdWYiDaKbJQ21 ZoVZ17AA/0i0QhZHs8CvQ8D/cSKVisU8cdj5qey4IlsAWd72DucnqMCWtDqbImgbks XskkB3y3v5NI5mcfuKQFUOYHoenMSHm5paEqXF4c= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E8D67605A2; Mon, 29 Apr 2019 14:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556549555; bh=Wjq2h5vre5y0bW0Mr5l5Eu4XzsvQkhOSmyWFDH05/FU=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=AahlZjU1YiDWu2rDT4H7hUmAMySaH1kdGujraYz15Eqt1v7npeXTeYjVzhxUbqJ8e pLcHYtCnDMd6AXIb6Og84J4Kvg/tPQEqnMxeYbVH0dwI+GX7yuIliaNwpb4EiY9O7A tEk77Rps2I062V73ol1v4ifbvQcDHpvTBKpa5Pj0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E8D67605A2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] ath9k: Don't trust TX status TID number when reporting airtime From: Kalle Valo In-Reply-To: <20190307183944.11190-1-toke@redhat.com> References: <20190307183944.11190-1-toke@redhat.com> To: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless@vger.kernel.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Miguel Catalan Cid User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190429145236.D162E60E41@smtp.codeaurora.org> Date: Mon, 29 Apr 2019 14:52:36 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Toke Høiland-Jørgensen wrote: > As already noted a comment in ath_tx_complete_aggr(), the hardware will > occasionally send a TX status with the wrong tid number. If we trust the > value, airtime usage will be reported to the wrong AC, which can cause the > deficit on that AC to become very low, blocking subsequent attempts to > transmit. > > To fix this, account airtime usage to the TID number from the original skb, > instead of the one in the hardware TX status report. > > Reported-by: Miguel Catalan Cid > Signed-off-by: Toke Høiland-Jørgensen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 389b72e58259 ath9k: Don't trust TX status TID number when reporting airtime -- https://patchwork.kernel.org/patch/10843731/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches