Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4716047yba; Tue, 30 Apr 2019 03:14:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqxs/qZTM55R69lmJUt5dxqQGuYpGawArAI/VD1rTfpdpJ2eYpAyvC93aauTCmG6nsimJykA X-Received: by 2002:a17:902:9686:: with SMTP id n6mr69478400plp.282.1556619254777; Tue, 30 Apr 2019 03:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556619254; cv=none; d=google.com; s=arc-20160816; b=X15MeveARwk1PPRXVHFrq0O4m7BKi5LFN/B0tWQ7lNrDf00ljLi/aPjCXsmSW0vkzy ENr+QCvgqJLcVeAC+zgdOZxuM40gQ9DWwpgZolYCqLOrPHrApXu6piVxxbxetNUT/LdZ Vddx7r58IjkZIpkqAO3T7EcAqtaFH8INuVOOfUFmWKvY5a7UmeMsp70fB373DGq/rIEG ljCetwbjZRojTXfKa9xQ+ovJXmRq/KpJ7PBMsmo0JT/MNhhIryb6OFLe62mz/tqm36nd D734ZoxJ9LLXTEY81+rzzZ23ZmFsb0MYrkGghWUYLCeA6K3OLy/+dL/e53qtx+OFvbqV t5sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:cc:to:from:thread-topic:subject:dkim-signature; bh=rrUMEH95nmE6FYFk5GaBxsAV8cn8/SLfYGtISMGfzPg=; b=IB38AwwtmHTJV0sK7g/GvnULjzTckOpJ56RvSV7Bc5JEVVM1cwJXpb/wzC+bm9qNrQ xmsoggEeFTqiRJj3Lov96XypYkPT4NVK2T3QHBzSM2WETB3XCmltmXARJdSdeTtvSlV+ KAXpqhKXsmXL5ErbisHo7sJHu5BFNDDs7y3ZcuuUCQXM5FirKXHvtrKRP1pXNrdkFwb0 l0ejR2z+ukZodHzOM/p+aMZX/3K/9AAd5a8Ooy3QyINMo5itI44w1c9Sx33ClPHQI1a/ 615Z3IkJwt67pIkUtj9aM8m683OYqrHB4PpqW0b6xURJVuSBCi+wwyd0bWzOfyqoVSoi sMfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@qti.qualcomm.com header.s=qcdkim header.b=CYx09mfc; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=qti.qualcomm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61si37005638plq.2.2019.04.30.03.13.59; Tue, 30 Apr 2019 03:14:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@qti.qualcomm.com header.s=qcdkim header.b=CYx09mfc; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=qti.qualcomm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbfD3KMQ (ORCPT + 99 others); Tue, 30 Apr 2019 06:12:16 -0400 Received: from alexa-out-tai-01.qualcomm.com ([103.229.16.226]:6750 "EHLO alexa-out-tai-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727147AbfD3KMP (ORCPT ); Tue, 30 Apr 2019 06:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1556619134; x=1588155134; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=BZotg9k9E1CKXnw/zm8MhESu2Ja8QFGo/7IeWgypMlU=; b=CYx09mfc+yejpK194UV4jEyucrKBOd3u599RChRmejQW971ONvc24cv7 EQEbTzE+gQnhlZzO1Yr8mncy7a4MqpvWC9pOwSzQi/O4Mdk1OKN178lUn tZeyyXjPUvTsqbAKYlmxbVy/R1SkyA/pzh3E/yxMpjkp12ABKTps09Qq4 k=; Subject: RE: [PATCH] ath10k: add peer id check in ath10k_peer_find_by_id Thread-Topic: [PATCH] ath10k: add peer id check in ath10k_peer_find_by_id Received: from ironmsg01-tai.qualcomm.com ([10.249.140.6]) by alexa-out-tai-01.qualcomm.com with ESMTP; 30 Apr 2019 18:12:12 +0800 X-IronPort-AV: E=McAfee;i="5900,7806,9242"; a="28185922" Received: from aptaiexm02b.ap.qualcomm.com ([10.249.150.12]) by ironmsg01-tai.qualcomm.com with ESMTP/TLS/AES256-SHA; 30 Apr 2019 18:12:12 +0800 Received: from aptaiexm02f.ap.qualcomm.com (10.249.150.16) by aptaiexm02b.ap.qualcomm.com (10.249.150.12) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 30 Apr 2019 18:12:10 +0800 Received: from aptaiexm02f.ap.qualcomm.com ([fe80::4152:1436:e436:faa1]) by aptaiexm02f.ap.qualcomm.com ([fe80::4152:1436:e436:faa1%19]) with mapi id 15.00.1395.000; Tue, 30 Apr 2019 18:12:10 +0800 From: Wen Gong To: "kvalo@codeaurora.org" , Nicolas Boichat CC: Claire Chang , "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" , Wen Gong Thread-Index: AQHU/naVjdeK9KpvqkiaD4Ar16f1/qZUc6BggAAJjYA= Date: Tue, 30 Apr 2019 10:12:09 +0000 Message-ID: <7d528d143ae14de2a489c6986f71ac45@aptaiexm02f.ap.qualcomm.com> References: <1554260478-4161-1-git-send-email-wgong@codeaurora.org> <87wojbrg0m.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87wojbrg0m.fsf@kamboji.qca.qualcomm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.249.136.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > -----Original Message----- > From: ath10k On Behalf Of Kalle Valo > Sent: Tuesday, April 30, 2019 5:37 PM > To: Nicolas Boichat > Cc: Claire Chang ; linux-wireless@vger.kernel.org; > ath10k@lists.infradead.org; Wen Gong > Subject: [EXT] Re: [PATCH] ath10k: add peer id check in > ath10k_peer_find_by_id > >> --- a/drivers/net/wireless/ath/ath10k/txrx.c > >> +++ b/drivers/net/wireless/ath/ath10k/txrx.c > >> @@ -157,6 +157,9 @@ struct ath10k_peer > *ath10k_peer_find_by_id(struct ath10k *ar, int peer_id) > >> { > >> struct ath10k_peer *peer; > >> > >> + if (peer_id >=3D sizeof(peer->peer_ids) * BITS_PER_BYTE) > > > > I'd use >=3D BITS_PER_TYPE(peer->peer_ids). >=20 > Nice, I didn't know about that. Wen, please submit v2 using this. >=20 > -- > Kalle Valo Yes,=20 I have send v2 yesterday: [PATCH v2] ath10k: add peer id check in ath10k_peer_find_by_id >=20 > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k