Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4729261yba; Tue, 30 Apr 2019 03:28:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqybSd2zvJGANXv4Hd6oRBRy2xFnslwC3iIJwAhl6MlydL8NuB1MuG066iczS5dY4zAUc7fk X-Received: by 2002:a65:6392:: with SMTP id h18mr64383167pgv.273.1556620123998; Tue, 30 Apr 2019 03:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556620123; cv=none; d=google.com; s=arc-20160816; b=Eme4AGVEUnrZs9bqc79Gu3nefDzn3gkNj9gictkZDRSSHTfZzPNipTYr6tHBeFzZT+ fibrYg/K1wmuXip8kVE8KNBmszxej7YeBlUZjr6MESZMQfHkZ0bXNKLLv9phVKg3+g75 ZglumZg4qXyWSJTOIN1IMWrqn3eMUjXWHgpXozdFWc5kmkLSjt4DeSA/G88HiJ3ClAOH pcNpoGia9mbDIh7gHhnZoJjWavXomr65bmbrwmipUZuG7TUfCamP/vBtUTG1otf2/zW3 OI/j9ScMe6MwAM1M8UVQAxkVsh3UyTS/MCDTV8cbB2cPsqwPGHUs42uOfBKonB5bYFlQ XMjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=jHyQ7BL4fIVLmJkHrtNG2K4NqIlxR+ui8EVUHBLojs0=; b=MTi1/iIJMtElmZLzUiZLungoiiSW0n/ysYni+hmIlYiD6yQOcavYBMJOUdDHG/PwNt DpKCNRhOkB1lMHgkbx4dZlQg1tBO0cEpdxWBKiC91Qi2S7yllv6UAZNpi38xjEQIgQt1 tNfZBJIs48yzOEr5Arpw3LW7bB+CUK4JJQCSv1LG6n6Rrgxg1NBy3JNmi5uaS6zlcugW 013DSZLWYlxl2sRzjJl9g4hU0UIxTx1xj+YqUvfHz4ytFk8NeAfeM+AKT87LzcNhsxGC +ykNTOixppNem+KSNoVZMviwP9i4UOObf5eCxJQwpU6XzaxKu+pdPcSrEK6Unjr9696j hUdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=nfMQQPPw; dkim=pass header.i=@codeaurora.org header.s=default header.b=SQMrHhkr; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16si22643293pgl.194.2019.04.30.03.28.23; Tue, 30 Apr 2019 03:28:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=nfMQQPPw; dkim=pass header.i=@codeaurora.org header.s=default header.b=SQMrHhkr; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbfD3K0h (ORCPT + 99 others); Tue, 30 Apr 2019 06:26:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34824 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbfD3K0h (ORCPT ); Tue, 30 Apr 2019 06:26:37 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D73B960364; Tue, 30 Apr 2019 10:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556619996; bh=sgiLu3f+W3ECwwR60iT9KF37xl0ExLR1aYqfc4yZinc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nfMQQPPwpZQIzvHhB4wppPFJwzR/to07q6KpW8j+h68gpjSA7vFA1YZ/+e+kZ6mFD cFuIOFl+KpRCgxePLTTlr15PGjdYA3Qzh3Uwt7icg8YHtw4SKyMcKfjjOLpo+9R/dI wx5esYMjTA5ztka9vbBOCOw3/oMP6zy1l1DdTamU= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9D0E560364; Tue, 30 Apr 2019 10:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556619991; bh=sgiLu3f+W3ECwwR60iT9KF37xl0ExLR1aYqfc4yZinc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SQMrHhkrIsPRP0d9gqNzAlUr889kuoPQSSJQo325L7vE4fQOWb7hJiYud8hGeutCn LoB2MPi9Au9po8YJXO+xIpPDKV5wQJnRDRDYSg5PEpXSDiOjpH5xXqSFNC6HMS51hr Dr5sFC6nE9Mqx9ToiKej9uksl5RT3Sjfl2guw/Kg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9D0E560364 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Cc: , , , , , , , Subject: Re: [PATCH v9 09/14] rtw88: chip files References: <1555653004-1795-1-git-send-email-yhchuang@realtek.com> <1555653004-1795-10-git-send-email-yhchuang@realtek.com> Date: Tue, 30 Apr 2019 13:26:26 +0300 In-Reply-To: <1555653004-1795-10-git-send-email-yhchuang@realtek.com> (yhchuang@realtek.com's message of "Fri, 19 Apr 2019 13:49:59 +0800") Message-ID: <87d0l3rdpp.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org writes: > From: Yan-Hsuan Chuang > > chip files Realtek 802.11ac wireless network chips > 8822B & 8822C series files > > Reviewed-by: Stanislaw Gruszka > Signed-off-by: Yan-Hsuan Chuang [...] > +static struct rtw_pwr_seq_cmd trans_carddis_to_cardemu_8822b[] = { > + {0x0086, > + RTW_PWR_CUT_ALL_MSK, > + RTW_PWR_INTF_SDIO_MSK, > + RTW_PWR_ADDR_SDIO, > + RTW_PWR_CMD_WRITE, BIT(0), 0}, I see lots of arrays like this which are not const. I think they should be const. -- Kalle Valo