Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp385082yba;
        Fri, 3 May 2019 03:50:44 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwazi6uQdpWkluRHB3UXvO9Em2vsaDo/YwGKu1PpDkuFEQzahroh0ZHoHNALfFQjNaekmDu
X-Received: by 2002:a62:30c2:: with SMTP id w185mr9937705pfw.175.1556880644559;
        Fri, 03 May 2019 03:50:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1556880644; cv=none;
        d=google.com; s=arc-20160816;
        b=MMYkT9Y0NpzZOZ3MmaRZPUU1TI9J5W8WHgMrFCHuupSAFlJlB54UiEogOkvhb+OQla
         vdEUg3D093fA952SeP4LpcIGVCMaqNLuZdE50N+n0LIX5NZT3RfQ6sC9GKMDd8lZoEIp
         JNYsOmYwgA2PmV6nUzWUPfE96as5QP35TtMtzn1g5IY21z+i3wkYXiECn/NO9H6xzCQU
         mSLPtX4XDe1yA/HmS7fiirTwyiQva7eqv/CQkII4kNbQ8QcdzvgPKV87WJ9LapLXU22G
         KD2tX1FfgXbOZw8HJ+7xDTbnRReo+yqobyH1DRweU+OmfcL7FQfdyeoRBXDg0vQm6XRI
         iF0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:date:cc:to:from:subject:message-id;
        bh=JV9nfBWNbz2FeW4EciOrKuM0amSO1WqNNlGwhZaRbY4=;
        b=dRshb61hG/UC1Gl2AsG3HAVMtscWJULAlokwUbSVCzjndPY2XRoGNCS9H0OQdbOLez
         5eF+ifM7wfGcHyC9fXHUaAf1KQTxiboYpx0RjUAT54VYJpfRgF0Rikx7tYr4nmAZKEGW
         xOq5GTmkzrugwvn1T3nfxaoZdfh0hrjvT6nL0RU/Uo7SfG9IvgkcBZ4dhjMPFt4ACKrs
         vOH+vwbmKE/xrmKeEWINu26ibaM6ueQCeWqTQGXxS1L+f6TUZWNhv3dWEr2SwDWgEDxd
         Jdhexk3r+VVHClrEZMXkljONiTqw+CVoZykSANWY4XKFw5anNa9ncr54ZsXKOsswkLCa
         ItwA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 64si2010007plb.303.2019.05.03.03.50.24;
        Fri, 03 May 2019 03:50:44 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726377AbfECKtG (ORCPT <rfc822;neojou@gmail.com> + 99 others);
        Fri, 3 May 2019 06:49:06 -0400
Received: from s3.sipsolutions.net ([144.76.43.62]:53336 "EHLO
        sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725816AbfECKtG (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Fri, 3 May 2019 06:49:06 -0400
Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
        (Exim 4.92)
        (envelope-from <johannes@sipsolutions.net>)
        id 1hMVkT-0005mQ-QO; Fri, 03 May 2019 12:49:01 +0200
Message-ID: <315fea6071bc29c20b3f71f8e725433c64ad195d.camel@sipsolutions.net>
Subject: Re: [PATCH 5/6] rtw88: mac: remove dangerous while (1)
From:   Johannes Berg <johannes@sipsolutions.net>
To:     yhchuang@realtek.com, kvalo@codeaurora.org
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 03 May 2019 12:48:58 +0200
In-Reply-To: <1556879502-16211-6-git-send-email-yhchuang@realtek.com> (sfid-20190503_123228_124010_1BC9DA36)
References: <1556879502-16211-1-git-send-email-yhchuang@realtek.com>
         <1556879502-16211-6-git-send-email-yhchuang@realtek.com>
         (sfid-20190503_123228_124010_1BC9DA36)
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Fri, 2019-05-03 at 18:31 +0800, yhchuang@realtek.com wrote:
> 
> +	while ((cmd = cmd_seq[idx])) {
...
> +	};

That semicolon is pretty pointless there :-)

johannes