Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2219122yba; Mon, 6 May 2019 01:49:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwIhbprtMT6C6yeX2qIF8frkbefW13Aa7rms/uprhkLsbrlGn0TQ4zkZm3CQVqePo5NNNCc X-Received: by 2002:a17:902:1c7:: with SMTP id b65mr30119786plb.2.1557132556475; Mon, 06 May 2019 01:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557132556; cv=none; d=google.com; s=arc-20160816; b=q0MCcKiWT1XNJztCkEhSNDbDYPH8YGv+yBWhpTWg8aBxQk56TPfIwM4XAo2fSIr0VN r4L1LOjBf680HLkNAfOrVQagjZS2zTwZ6fL+62QdDigSsxPCxz3wRilLxEyQxzFvYcyE C4Y4Med8ba2s9HP0la8YqNVOT99RnrOff0QKoTZdBDmR7370R6u0bbrmcxLKhAxln16J gP2GYeykgnMS4AYrjnKmJ9pTeHWAFJHywSeJbDYEFcVrXA2FqdhR/P0Z1Ssd8M8/MzWT S37EnIvSHxZIbyCO9hWvh1s35ndtaM3DgkUwRoQg9g7p9z1gaLNK4HH5rI9lewEVVfce Ckzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=P6RTUFtHirMh6Mu8AEY30eOlREtd3lQ1Apkh4ugkG/g=; b=Cm/pFafGKEQOcZkPZkilFRfXd+gsQAGf+9gj0sP7CNqGchntW1Zm653UjDCaNCNCYl H2Ffadn5W78fNxGkiQZ5F/c+ADwULGE/s1IdsSq2J2PcgV+vGoEy+/iJLcLC3DXTdxZE uQWG3cOxNowU9Fattv3kyS8KPolKKFT4hD3KCBzntYNyokLBRDtcgqd7lX4BjHopxZAG YkxjK9sO3hwID0T/m1AGWKpdRapurYPb+qY1JpULNZGnA/lphqbiGs/qnxSG7ldhX/3W KdJor7rYYNxD+lPCkYE6y+EBMh1ccLDyUItwE+NKrFYYvLGBqJAWf53XnUEwZyCO1hos OGlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=eeSB8pUI; dkim=pass header.i=@codeaurora.org header.s=default header.b=eeSB8pUI; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f191si13400778pgc.570.2019.05.06.01.49.01; Mon, 06 May 2019 01:49:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=eeSB8pUI; dkim=pass header.i=@codeaurora.org header.s=default header.b=eeSB8pUI; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbfEFIsq (ORCPT + 99 others); Mon, 6 May 2019 04:48:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50588 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbfEFIsq (ORCPT ); Mon, 6 May 2019 04:48:46 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 79D93607B9; Mon, 6 May 2019 08:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1557132525; bh=cIyZQv7s3OiUpByuX8bv38ZcAkFQrQ+TiDmlgJT2lJs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eeSB8pUINf4NLJ4Lf+kO9OExZRshoaTqnHrxNhVmzW1fhtLBB3uAOmA5+pksQ5Z8U J79u8JzDB7yXMh5aL9mKaZLzdkidZ/HneUnaeFM1DUm5FORmtydMQembNZbpb/w5Q0 +sVBtoYf86ZGfRv20OQ+QpEbvH7qmWCz0Rq17gHI= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A2124602DC; Mon, 6 May 2019 08:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1557132525; bh=cIyZQv7s3OiUpByuX8bv38ZcAkFQrQ+TiDmlgJT2lJs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eeSB8pUINf4NLJ4Lf+kO9OExZRshoaTqnHrxNhVmzW1fhtLBB3uAOmA5+pksQ5Z8U J79u8JzDB7yXMh5aL9mKaZLzdkidZ/HneUnaeFM1DUm5FORmtydMQembNZbpb/w5Q0 +sVBtoYf86ZGfRv20OQ+QpEbvH7qmWCz0Rq17gHI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A2124602DC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Cc: Subject: Re: [PATCH v2 4/5] rtw88: fix unassigned rssi_level in rtw_sta_info References: <1556884415-23474-1-git-send-email-yhchuang@realtek.com> <1556884415-23474-5-git-send-email-yhchuang@realtek.com> Date: Mon, 06 May 2019 11:48:41 +0300 In-Reply-To: <1556884415-23474-5-git-send-email-yhchuang@realtek.com> (yhchuang@realtek.com's message of "Fri, 3 May 2019 19:53:34 +0800") Message-ID: <874l68vuhi.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org writes: > From: Yan-Hsuan Chuang > > The new rssi_level should be stored in si, otherwise the rssi_level will > never be updated and get a wrong RA mask, which is calculated by the > rssi level > > Signed-off-by: Yan-Hsuan Chuang Stanislaw suggested that this should go to 5.2. So what breaks from user's point of view if this is not applied? -- Kalle Valo