Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3688619yba;
        Tue, 7 May 2019 05:36:41 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxaEGO2VRA3jIf25CBWihyTPL5o4AcjPKO6seEKdzwEDCQihTr+oniWvxUIq6gvxcvujtp1
X-Received: by 2002:a17:902:7084:: with SMTP id z4mr17120298plk.259.1557232601074;
        Tue, 07 May 2019 05:36:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1557232601; cv=none;
        d=google.com; s=arc-20160816;
        b=l6okdLpVJPDjod07qCEQIbOotxeV/oofHHKex7vYlbWA9RvCrk3dnXsJh8uK7gtgt9
         7NPgID1lcfH+pyE/yiqV/t7o2U9MbFFENktXi2Ol7Yg301BftELLQWYctZlS7j0HeEGX
         zGzEjQO9u0+uF6YCAbkBLaiAJoF1efXJmVMMeKKsQR1XrXw5e65o7nw5gVHu5B1aZFCr
         Xp2/RAS5HeEOG0mvHoFP9hmDSs2DthsOkaMLna1UNcAxbl0RzTGfvysAkXlxqzYkC6ZB
         itFJ84N2iyEay+F7j/rH8JzGQdr9SVC6BN139bPR9dUpj1Qgsf74DAb49SDqsLZKptj4
         vvTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=REpAZBJxBwUZS5+QTaYKzDWfuLkef2EJbop8FtwTMFU=;
        b=kkBtG1pDT+fZqJu57xruzvC/zjcr5TJn5pyGRYCdedHAc58mx6CZvKZRh8oaezicC4
         5z5mCKI7O4tD+eFz+EErr3K9PA2EbHEu9/dK7T7p6RwLUJD616AxTsZgsYvm3+TVQUm/
         7ns4bBIWGwR5bIlhuYpYx0wti+9Hd2xcj9rKSZUDoJtazlF4P1qzo+pSvU33tEmz+Oxe
         qDnNgQbqC46TOQ3bEI6/TYAV98T5CVW9eH+yZxCjx2tAjPtyeo4LR/sXaUhegIAUbdie
         qmC/ViBsbt4s/SUVecrkp3oUywdH3alEQixf/ClBnTAN9oKd3cidRkSFzdqEL9sCZWUa
         WOGg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id m134si19383537pga.588.2019.05.07.05.36.11;
        Tue, 07 May 2019 05:36:41 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726206AbfEGMgK (ORCPT <rfc822;neojou@gmail.com> + 99 others);
        Tue, 7 May 2019 08:36:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58698 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725858AbfEGMgK (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 7 May 2019 08:36:10 -0400
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id B035930821A3;
        Tue,  7 May 2019 12:36:09 +0000 (UTC)
Received: from localhost (ovpn-204-114.brq.redhat.com [10.40.204.114])
        by smtp.corp.redhat.com (Postfix) with ESMTP id 3C02564050;
        Tue,  7 May 2019 12:36:07 +0000 (UTC)
Date:   Tue, 7 May 2019 14:36:07 +0200
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
        pkshih@realtek.com
Subject: Re: [RFC] rtlwifi: rtl8821ae: Use inline routines rather than macros
 for descriptor word 0
Message-ID: <20190507123606.GA5076@redhat.com>
References: <20190506173916.16486-1-Larry.Finger@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190506173916.16486-1-Larry.Finger@lwfinger.net>
User-Agent: Mutt/1.11.3 (2019-02-01)
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 07 May 2019 12:36:09 +0000 (UTC)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, May 06, 2019 at 12:39:16PM -0500, Larry Finger wrote:
> The driver uses complicated macros to set parts of word 0 of the TX and RX
> descriptors. These are changed into inline routines.

Why not use le32p_replace_bits() like rtw88 in 
drivers/net/wireless/realtek/rtw88/tx.h ?

Stanislaw