Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3225975yba; Sat, 11 May 2019 06:30:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxltxIUNYBNoIjmdFtRREbelfLmy8SkwQ+YPmpT+veGClaokssdSOMsi4q4qCMXyOMUEO3T X-Received: by 2002:a17:902:2a28:: with SMTP id i37mr19099831plb.47.1557581402804; Sat, 11 May 2019 06:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557581402; cv=none; d=google.com; s=arc-20160816; b=PiF+R8PvU7DexepcNbOw78d4YFWVMKGmng6TVDrkx/N9HjUHmUopOi/OSH0/5jHRPk PTBr4h512OG/PxpQRdUgSZ7dyXsZoYJcUF3HdmbSBfrtELI5yb/zgp32LNTY3VJQY3M7 tAiVQj4F21RRWJygPd5vKcB7SCSYWuYMsVDJKNEcndr7Ew4VFHM2ERFe061Ug9y0/u3N L0qBzrbfDkhOn/30UjvXIN0TXwnzDGCEwKU5ujEuPUzhlbKJZ71ovCMAaISKRTdKiivH GSLuHGwew/HZXJzmPkRB+uk/7Hj48+446qBB9Q7xzhSWtb2OIxzftMcX+rUf04/WojLC K5RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=mdvjgPMA9eI8DprNFHPPXca19zBL7cdKnNyLoDx9Ga0=; b=KZb5u66k1XGM7yigJPi6a/QX6MlQj/Z2XPrn6bqw2YXdNflY1MEkhknCNEliUUJmGx LfiDMBWfefg7yaHogqYvbh0Qe0kp0l4+KUD49Vy+oqKbYyaIWVQ904nFrskPNcqDFByE fltHuOcfrdtdRpomJ1HJO2TiQY01yKfv5t5RoOQLPycZ/vUcyG8pG0jSk5iXWdJGVbsZ z4fh/caR7kPMVEmRFX934dgrAXpnSUcIV3/C1J7ZhWh6gva/9HyRuN4jAu5qGVRI2xVb J8NNboPVPxIoDY3+Ys8fvqItyAt4r/6eU+vHa4NYKLht0H1lqQX4GeGm0BAskousv6nd k0Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=sS+6V2Sn; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i195si1239774pfe.20.2019.05.11.06.29.47; Sat, 11 May 2019 06:30:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=sS+6V2Sn; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728599AbfEKN3D (ORCPT + 99 others); Sat, 11 May 2019 09:29:03 -0400 Received: from nbd.name ([46.4.11.11]:55120 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbfEKN3D (ORCPT ); Sat, 11 May 2019 09:29:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mdvjgPMA9eI8DprNFHPPXca19zBL7cdKnNyLoDx9Ga0=; b=sS+6V2Sn8YFUOqu0V/2wEiKpWi ELbhxnofZ8dnUCQG0ncooK+ySrMewXD7wJXGOwyt8bIoy+rYo1KozYo3Afgi+pdD2mOngM9MjNltj /C8vn30bTUx+Vol69muawWXpPlpRGM0okIgR5Y1SITpuIP9Zkg3W1d5F7Yywm04oVy74=; Received: from p54ae9c89.dip0.t-ipconnect.de ([84.174.156.137] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hPS3g-00022e-8R; Sat, 11 May 2019 15:29:00 +0200 Subject: Re: [PATCH] mt76: Fix a signedness bug in mt7615_add_interface() To: Dan Carpenter , Ryder Lee Cc: Lorenzo Bianconi , Roy Luo , Kalle Valo , Matthias Brugger , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org References: <20190502212341.GA31847@mwanda> From: Felix Fietkau Openpgp: preference=signencrypt Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= mQGiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwbQcRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPohgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQuQINBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabiEkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: Date: Sat, 11 May 2019 15:28:59 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502212341.GA31847@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-05-03 14:54, Dan Carpenter wrote: > The problem is that "mvif->omac_idx" is a u8 so it can't be negative > and the error handling won't work. The get_omac_idx() function returns > -1 on error. > > Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets") > Signed-off-by: Dan Carpenter Applied, thanks. - Felix