Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4764493yba; Sun, 12 May 2019 22:08:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqxoK+DST2TbVMgV52U2bxximIKpxpxlzf3R8+XoiDULOvpC7sSpnhv1Y7H0+hMdHN9Tc7vV X-Received: by 2002:a17:902:9f8b:: with SMTP id g11mr22439636plq.199.1557724080072; Sun, 12 May 2019 22:08:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557724080; cv=none; d=google.com; s=arc-20160816; b=OE0vR4QQ0mfHd8ZCeEk4ysVrGPQj428+sC2hEmUzf2D8ZtkjJrPItbD/sk9wNDQjqu Dy4C2Qc8MFnFXnJ5qDJ+DQZ5zmvLzBkGdHO1JNx96HxwLNjzrm9LAyZRxEaIwzwAXFfN yGJebYMUBGOMSUuh+Mn+278OH4bdDDhfjwFnW+p0quAchX4GO8eFSoGGuxcnI6CL8uxj pfr+qF6DsAzmUDQD0xAmJ+zEn9aWbh29BI9dgHqUH76WDZq5wKtyphDe9GYiXNXAR78F ZZhB+whgq7YDkpRaJ2ArML54FCu0FwAwK2QqksIMvmVEE5UD/MBi1/0kBBkGjWh6Kpu6 tL5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=Wmq4U/GTrtvOU97BJrXAzaNlYT2jI7GZvrfgKTgFx4w=; b=HkhMZ3KI2bba2YgeqQnUizBVu24VlLVmxVhBo0nTsTIfiwAADEiXgnsN+NfKTB/3Vt 1tcN24c7FjQkCY8hwIM4ap26u+e0BFRjet48+FpN0JyjzOL0O1UcGsZe31/IGkBOTJUj ufII24f4aZg72qteiH/wWUA85rdhSoPhyQjZMOymsihScRF+xMXkAuo9fxcmkOR/FbIN 112YqHd4giMHiXW44Ltz0lrtx9bUdlyzKqQbUGT2u+X8jShXc1RxtHP0j4H0mADxbDZA 4idLshCFz6F3tqyhbcmJADThFBHoL1XjvphURfB4R1e1kSjQjrGRHb2u3qmVUSSb/Bru 0l/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=a1gWc25C; dkim=pass header.i=@codeaurora.org header.s=default header.b=a1gWc25C; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n81si16247739pfb.258.2019.05.12.22.07.28; Sun, 12 May 2019 22:08:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=a1gWc25C; dkim=pass header.i=@codeaurora.org header.s=default header.b=a1gWc25C; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727599AbfEME00 (ORCPT + 99 others); Mon, 13 May 2019 00:26:26 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59284 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726626AbfEME00 (ORCPT ); Mon, 13 May 2019 00:26:26 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7E18D6087A; Mon, 13 May 2019 04:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1557721585; bh=485jr2fpmuCxUnFiaDKxVVkRWaqD5BarJ7lAxJBh3Z8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=a1gWc25C3bWuFzHUKpBtEta8SHWWEXOMBBjcMdJAiBp1K0c4FedSr/JdCKRvwor4V Ffp/Ipp9mWBUPFIsD5bEJkkom5Z+SXJTVJgO6TWbpK4gBei0atbIjlg62fm6/pKZVF ynTzGDVz/slyHtN3Mzs+n/0sf7zOwhiea6M/iDZY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 502936032C; Mon, 13 May 2019 04:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1557721585; bh=485jr2fpmuCxUnFiaDKxVVkRWaqD5BarJ7lAxJBh3Z8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=a1gWc25C3bWuFzHUKpBtEta8SHWWEXOMBBjcMdJAiBp1K0c4FedSr/JdCKRvwor4V Ffp/Ipp9mWBUPFIsD5bEJkkom5Z+SXJTVJgO6TWbpK4gBei0atbIjlg62fm6/pKZVF ynTzGDVz/slyHtN3Mzs+n/0sf7zOwhiea6M/iDZY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 502936032C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Lorenzo Bianconi Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca References: <0691acb931e963cb6028d4687cdd61032d0aaf52.1557591530.git.lorenzo@kernel.org> Date: Mon, 13 May 2019 07:26:21 +0300 In-Reply-To: <0691acb931e963cb6028d4687cdd61032d0aaf52.1557591530.git.lorenzo@kernel.org> (Lorenzo Bianconi's message of "Sat, 11 May 2019 18:38:41 +0200") Message-ID: <87r293ugia.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Lorenzo Bianconi writes: > Introduce a knob in mt7603 debugfs in order to enable/disable > edcca processing > > Signed-off-by: Lorenzo Bianconi It's good to explain what edcca does and how the file is used supposed to be used. In other words, have a small introduction for the user. > @@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev) > if (!dir) > return; > > + debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca); Why 0400 and not 0600? -- Kalle Valo