Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6343569yba; Tue, 14 May 2019 06:09:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWiHfyURa81FznucpX+ZcuvD5InK9Tn1S/GekBxHzMeJU5hE+dCUHT88gqRSna3dm91EWi X-Received: by 2002:a63:7b1e:: with SMTP id w30mr32802750pgc.406.1557839348487; Tue, 14 May 2019 06:09:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557839348; cv=none; d=google.com; s=arc-20160816; b=xwjrE5bm7nb2MAH99znTYSzPLmDLqs49T9Usqq5RxcH/kOiPuABx0L6FtfvwR6t8zc HLWq9rXPD3Q2fBvK+IUmkHaXkYpNvViM2vzF3+FfNePxcsB9z9Kye7Tj9zLMrMijblUe xjoaqzCx8W5IJXvV98EkjJjDwfjDY6SDHqseOoMn/fK6kYkQo2wFkhWzJrpsUvdyInpR 0OqxXjS5J4aKlJSGBx6OOKDf8laAUPji9EK1/W2sgT8U4V94sn88pLtHrrHUewnRbZvY cEzRrSpEqunXsSTe9mN7779gjCHhJIql5BP9XerAXoAMiRpIURSBUUXKwEh4f4K/ezlu gR3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:mime-version:user-agent:date:message-id :subject:from:cc:to:dkim-signature; bh=HkTrup9eFQQ+oLlEDmRavF3Qjf2zdQSOrx8h9qp5+SQ=; b=WNzuj64SuOCj0e4oF/1UZnw24OxtyolVLjHOXyfHlr1D2eQ/MYn+O2+9gI3Ke+kJz2 jCzypbbDtOMb4DsPHC81BhPnzy7oK47Itfhq7S6u5rM2i7kXko4QM6EoZVAYk9THuZz5 TSQ+wyspnz7dfA1tzjVWWafFDNbBzg3T25e1Fc29rCFfHrAsLcO6d9VrK8oFPwwItvUr L83ZAXS7g0b8bhkHRmUrpnjMUpYpUxJRepxQlJNaopBT3zKK3e53t89AlMEoYEJTkXjP iw/B8gQGTAq/o17vFkaHfH0l6f+utCkpZ8Y/p4LkLUDCEpWo/CFcy0Gfya5LAgC9KS0I FOIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AYYyR+Ex; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si21021915plb.347.2019.05.14.06.08.40; Tue, 14 May 2019 06:09:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AYYyR+Ex; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725928AbfENNIE (ORCPT + 99 others); Tue, 14 May 2019 09:08:04 -0400 Received: from mail-pf1-f171.google.com ([209.85.210.171]:45483 "EHLO mail-pf1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbfENNIE (ORCPT ); Tue, 14 May 2019 09:08:04 -0400 Received: by mail-pf1-f171.google.com with SMTP id s11so9102556pfm.12; Tue, 14 May 2019 06:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=HkTrup9eFQQ+oLlEDmRavF3Qjf2zdQSOrx8h9qp5+SQ=; b=AYYyR+ExyOp9KaKCIYiyM8TaijaswJ4nql8ZYcwkMKNLB6qQn2w1u4/b3ykklPbopa kUJCqAeNf9pNXqpeDOLXfY5W33ozl7X7pDq2vEaG5gzyGPNZmF2+lZz2L9NTJs+9NvpA zrc1MdQJyK3EY0fEoxZ+PZL3q7GO2ZaY+hePqezPY8IZXt/SbAiz1XMpFEcDDc+He1je 9WnMaCxkHNZ2TpuDNwON4F24r6MgecQk2byObXMiwzuGgfpLxfDyNvaYOGsCxUqii3Ly TFSDOqWXhYRxWHi48yfwNMuF8bZRFKETxiWBEpYuz4AcCxSAFt9mPK8NOZSbYxUbqAAX TnmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=HkTrup9eFQQ+oLlEDmRavF3Qjf2zdQSOrx8h9qp5+SQ=; b=hUHlINM2E0h23XGuOQbpKM2a54HMqpHIkwg8frfb6N6xc9wqADAi/8Z2lp7tNrmthg 3d6KKVEiCnOmzyFbYDSFlz0TCDumEiQ5qCbjUge3QEFPoFY2Z1iUVGAVBYUFaimpMG3D Uk8CzhZi7PRm7wA+0cVkRKLbKcDbCR2gmxQjrMdrNH9jJueqOLeoSuO/1T5GdafBRKgc P0ZzgFu93kz1Jn2/y3DLy3l3SERHDUo2hxEOE6rPuEAKDt1ZMb4XUWhKuSVQ9wMzNVfv eM2bxnXBb0z4cihVF5tn6m0Ay0Xeydl9Xa47s/+l1SPdDHTCrs0CBIN9Zg0DB9AJG28U 7s4w== X-Gm-Message-State: APjAAAUpCA5mCkmDO0DbCfLZwMiG0FMPYn95z5yw5eHK+d1dO44kUWHZ 5cOAS/cj03ysf2euLzXHYLeQmUjz X-Received: by 2002:aa7:87ca:: with SMTP id i10mr14451676pfo.157.1557839283140; Tue, 14 May 2019 06:08:03 -0700 (PDT) Received: from ?IPv6:2402:f000:1:1501:200:5efe:166.111.71.27? ([2402:f000:1:1501:200:5efe:a66f:471b]) by smtp.gmail.com with ESMTPSA id h14sm542472pgj.8.2019.05.14.06.08.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 06:08:02 -0700 (PDT) To: pkshih@realtek.com, Kalle Valo , David Miller Cc: Linux Kernel Mailing List , "linux-wireless@vger.kernel.org" , netdev From: Jia-Ju Bai Subject: [BUG] rtlwifi: a crash in error handling code of rtl_pci_probe() Message-ID: <4627da7a-c56c-5d88-62ae-ea2be9430f6f@gmail.com> Date: Tue, 14 May 2019 21:07:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org In rtl_pci_probe(), when request_irq() in rtl_pci_intr_mode_legacy() in rtl_pci_intr_mode_decide() fails, a crash occurs. The crash information is as follows: [ 108.271155] kasan: CONFIG_KASAN_INLINE enabled [ 108.271163] kasan: GPF could be caused by NULL-ptr deref or user memory access ...... [ 108.271193] RIP: 0010:cfg80211_get_drvinfo+0xce/0x3b0 [cfg80211] ...... [ 108.271235] Call Trace: [ 108.271245] ethtool_get_drvinfo+0x110/0x640 [ 108.271255] ? cfg80211_get_chan_state+0x7e0/0x7e0 [cfg80211] [ 108.271261] ? ethtool_get_settings+0x340/0x340 [ 108.271268] ? __read_once_size_nocheck.constprop.7+0x20/0x20 [ 108.271279] ? kasan_check_write+0x14/0x20 [ 108.271284] dev_ethtool+0x272d/0x4c20 [ 108.271290] ? unwind_get_return_address+0x66/0xb0 [ 108.271299] ? __save_stack_trace+0x92/0x100 [ 108.271307] ? ethtool_get_rxnfc+0x3f0/0x3f0 [ 108.271316] ? save_stack+0xa3/0xd0 [ 108.271323] ? save_stack+0x43/0xd0 [ 108.271331] ? ftrace_graph_ret_addr+0x2d/0x170 [ 108.271338] ? ftrace_graph_ret_addr+0x2d/0x170 [ 108.271346] ? ftrace_graph_ret_addr+0x2d/0x170 [ 108.271354] ? update_stack_state+0x3b2/0x670 [ 108.271361] ? update_stack_state+0x3b2/0x670 [ 108.271370] ? __read_once_size_nocheck.constprop.7+0x20/0x20 [ 108.271379] ? unwind_next_frame.part.5+0x19f/0xa60 [ 108.271388] ? bpf_prog_kallsyms_find+0x3e/0x270 [ 108.271396] ? is_bpf_text_address+0x1a/0x30 [ 108.271408] ? kernel_text_address+0x11d/0x130 [ 108.271416] ? __kernel_text_address+0x12/0x40 [ 108.271423] ? unwind_get_return_address+0x66/0xb0 [ 108.271431] ? __save_stack_trace+0x92/0x100 [ 108.271440] ? save_stack+0xa3/0xd0 [ 108.271448] ? udp_ioctl+0x35/0xe0 [ 108.271457] ? inet_ioctl+0x100/0x320 [ 108.271466] ? inet_stream_connect+0xb0/0xb0 [ 108.271475] ? alloc_file+0x60/0x480 [ 108.271483] ? alloc_file_pseudo+0x19d/0x270 [ 108.271495] ? sock_alloc_file+0x51/0x170 [ 108.271502] ? __sys_socket+0x12c/0x1f0 [ 108.271510] ? __x64_sys_socket+0x78/0xb0 [ 108.271520] ? do_syscall_64+0xb1/0x2e0 [ 108.271529] ? entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 108.271538] ? kasan_check_read+0x11/0x20 [ 108.271548] ? mutex_lock+0x8f/0xe0 [ 108.271557] ? __mutex_lock_slowpath+0x20/0x20 [ 108.271568] dev_ioctl+0x1fb/0xae0 [ 108.271576] ? dev_ioctl+0x1fb/0xae0 [ 108.271586] ? _copy_from_user+0x71/0xd0 [ 108.271594] sock_do_ioctl+0x1e2/0x2f0 [ 108.271602] ? kmem_cache_alloc+0xf9/0x250 [ 108.271611] ? ___sys_recvmsg+0x5a0/0x5a0 [ 108.271621] ? apparmor_file_alloc_security+0x128/0x7e0 [ 108.271630] ? kasan_unpoison_shadow+0x35/0x50 [ 108.271638] ? kasan_kmalloc+0xad/0xe0 [ 108.271652] ? apparmor_file_alloc_security+0x128/0x7e0 [ 108.271662] ? apparmor_file_alloc_security+0x269/0x7e0 [ 108.271670] sock_ioctl+0x361/0x590 [ 108.271678] ? sock_ioctl+0x361/0x590 [ 108.271686] ? routing_ioctl+0x470/0x470 [ 108.271695] ? kasan_check_write+0x14/0x20 [ 108.271703] ? __mutex_init+0xba/0x130 [ 108.271713] ? percpu_counter_add_batch+0xc7/0x120 [ 108.271722] ? alloc_empty_file+0xae/0x150 [ 108.271729] ? routing_ioctl+0x470/0x470 [ 108.271738] do_vfs_ioctl+0x1ae/0xfe0 [ 108.271745] ? do_vfs_ioctl+0x1ae/0xfe0 [ 108.271754] ? alloc_file_pseudo+0x1ad/0x270 [ 108.271762] ? ioctl_preallocate+0x1e0/0x1e0 [ 108.271770] ? alloc_file+0x480/0x480 [ 108.271778] ? kasan_check_read+0x11/0x20 [ 108.271786] ? __fget+0x24d/0x320 [ 108.271794] ? iterate_fd+0x180/0x180 [ 108.271802] ? fd_install+0x52/0x60 [ 108.271812] ? security_file_ioctl+0x8c/0xb0 [ 108.271820] ksys_ioctl+0x99/0xb0 [ 108.271829] __x64_sys_ioctl+0x78/0xb0 [ 108.271839] do_syscall_64+0xb1/0x2e0 [ 108.271857] ? prepare_exit_to_usermode+0xc8/0x160 [ 108.271871] entry_SYSCALL_64_after_hwframe+0x44/0xa9 ...... I checked the driver source code, but cannot find the reason, so I only report the crash... Can somebody give an explanation about this crash? This crash is triggered by a runtime fuzzing tool named FIZZER written by us. Best wishes, Jia-Ju Bai