Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
To:     James Hughes <james.hughes@raspberrypi.org>
CC:     "linux-wireless" <linux-wireless@vger.kernel.org>
Date:   Thu, 16 May 2019 19:02:45 +0200
Message-ID: <16ac1989b08.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
In-Reply-To: <CAE_XsMKM5Q2obuKoVCBcpVtxGdhuEOp8a7nq=YP9ivNBOUz9Fg@mail.gmail.com>
References: <b04655c7-5a6e-b510-5fcf-30ecca489882@broadcom.com>
 <CAE_XsMKM5Q2obuKoVCBcpVtxGdhuEOp8a7nq=YP9ivNBOUz9Fg@mail.gmail.com>
User-Agent: AquaMail/1.20.0-1451 (build: 102000001)
Subject: Re: SPDX identifier
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="us-ascii"
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On May 16, 2019 4:17:55 PM James Hughes <james.hughes@raspberrypi.org> wrote:
> On Thu, 16 May 2019 at 12:36, Arend Van Spriel
> <arend.vanspriel@broadcom.com> wrote:
>>
>> Hi Kalle, Thomas,
>>
>> I added SPDX tags in brcm80211 driver sources. Although it is a
>> no-brainer I decided to run checkpatch for the changes and quirky stuff
>> started to happen. For all files I added:
>>
>> // SPDX-License-Identifier
>>
>> but checkpatch started complaining I should use /* ... */ instead of //.
>>
>> WARNING: Improper SPDX comment style for
>> 'drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h', please
>> use '/*' instead
>> #29: FILE: drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h:1:
>> +// SPDX-License-Identifier: ISC
>>
>> So I edited all patches and ran again. And again it started complaining.
>>
>> WARNING: Improper SPDX comment style for
>> 'drivers/net/wireless/broadcom/brcm80211/brcmsmac/aiutils.c', please use
>> '//' instead
>>
>> So now I am in a bonkers state. It seems for header files we want /* */
>> and for c files we want //. For real?
>
> https://www.kernel.org/doc/html/v4.17/process/license-rules.html
> explains why the comment style differs between .c and .h

Thanks, James

It explains why header files can not use //. Just wish the same comment 
style was chosen for the c files if only just to be consistent.

Regards,
Arend