Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 May 2019 19:03:33 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        ryder.lee@mediatek.com, royluo@google.com
Subject: Re: [PATCH] mt76: mt7615: add preliminary support for mtd eeprom
 parsing
Message-ID: <20190516170332.GA21478@localhost.localdomain>
References: <cover.1557853278.git.lorenzo@kernel.org>
 <80210f745a12498fc6fc0f2616c2afb43658f0f6.1557853278.git.lorenzo@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl"
Content-Disposition: inline
In-Reply-To: <80210f745a12498fc6fc0f2616c2afb43658f0f6.1557853278.git.lorenzo@kernel.org>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Calibration data are often available on a specific mtd partition on
> embedded devices. Take into account eeprom calibration data if
> available. Calibration free data parsing is currently missing
>=20
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../wireless/mediatek/mt76/mt7615/eeprom.c    | 32 +++++++++++++++----
>  1 file changed, 26 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c b/drivers=
/net/wireless/mediatek/mt76/mt7615/eeprom.c
> index dd5ab46a4f66..0313c604ea61 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c

[...]

>  int mt7615_eeprom_init(struct mt7615_dev *dev)
>  {
>  	int ret;
> @@ -84,7 +98,13 @@ int mt7615_eeprom_init(struct mt7615_dev *dev)
>  	if (ret < 0)
>  		return ret;
> =20
> -	memcpy(dev->mt76.eeprom.data, dev->mt76.otp.data, MT7615_EEPROM_SIZE);
> +	if (dev->mt76.otp.data) {
> +		ret =3D mt7615_check_eeprom(&dev->mt76);
> +		if (ret < 0)
> +			memcpy(dev->mt76.eeprom.data, dev->mt76.otp.data,
> +			       MT7615_EEPROM_SIZE);
> +		/* TODO: take into account cal free data */

reviewing sdk code it seems we do not have cal free data here, I will post =
a v2
removing the comment

Regards,
Lorenzo

> +	}
> =20
>  	dev->mt76.cap.has_2ghz =3D true;
>  	dev->mt76.cap.has_5ghz =3D true;
> --=20
> 2.20.1
>=20

--BXVAT5kNtrzKuDFl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXN2X4QAKCRA6cBh0uS2t
rNjZAP9/C/+xwUz9egyNUx9DbUpxgNbZm9Crzfzycwkzd3c9dQEA748mEPixqH3X
gT3pFkYOcprV1caxiuSlIM2NYIUiYwk=
=Isd7
-----END PGP SIGNATURE-----

--BXVAT5kNtrzKuDFl--