Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 May 2019 19:31:14 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Arend van Spriel <arend.vanspriel@broadcom.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/7] brcmsmac: switch source files to using SPDX license
 identifier
Message-ID: <20190516173113.GA540@kroah.com>
References: <1558008251-13692-1-git-send-email-arend.vanspriel@broadcom.com>
 <1558008251-13692-4-git-send-email-arend.vanspriel@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1558008251-13692-4-git-send-email-arend.vanspriel@broadcom.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, May 16, 2019 at 02:04:07PM +0200, Arend van Spriel wrote:
> With ISC license text in place under the LICENSES folder switch
> to using the SPDX license identifier to refer to the ISC license.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> ---
> Hi Thomas, Greg,
> 
> The file drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c
> did not have license information nor copyright notice and as such
> it got included in commit b24413180f56 ("License cleanup: add SPDX
> GPL-2.0 license identifier to files with no license"). I added you
> guys as I propose to align this source file with the rest of
> the driver sources and change it to ISC license and add the missing
> copyright notice while at it (not sure if that warrants a separate
> patch).

A separate patch would be good, to make it explicit that you are
changing the license of the file.

And ISC, ick, why...  :)

thanks,

greg k-h