Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/7] brcmsmac: switch source files to using SPDX license
 identifier
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>
References: <1558008251-13692-1-git-send-email-arend.vanspriel@broadcom.com>
 <1558008251-13692-4-git-send-email-arend.vanspriel@broadcom.com>
 <20190516173113.GA540@kroah.com>
 <a5d32b2f-a99b-a248-1acd-9de532732e30@broadcom.com>
 <20190516200131.GA15814@kroah.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <eeebea29-4237-6e49-7578-8d3b1ad7df85@broadcom.com>
Date:   Thu, 16 May 2019 22:15:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190516200131.GA15814@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/16/2019 10:01 PM, Greg Kroah-Hartman wrote:
> On Thu, May 16, 2019 at 09:45:19PM +0200, Arend Van Spriel wrote:
>> On 5/16/2019 7:31 PM, Greg Kroah-Hartman wrote:
>>> On Thu, May 16, 2019 at 02:04:07PM +0200, Arend van Spriel wrote:
>>>> With ISC license text in place under the LICENSES folder switch
>>>> to using the SPDX license identifier to refer to the ISC license.
>>>>
>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
>>>> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
>>>> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
>>>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>>>> ---
>>>> Hi Thomas, Greg,
>>>>
>>>> The file drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c
>>>> did not have license information nor copyright notice and as such
>>>> it got included in commit b24413180f56 ("License cleanup: add SPDX
>>>> GPL-2.0 license identifier to files with no license"). I added you
>>>> guys as I propose to align this source file with the rest of
>>>> the driver sources and change it to ISC license and add the missing
>>>> copyright notice while at it (not sure if that warrants a separate
>>>> patch).
>>>
>>> A separate patch would be good, to make it explicit that you are
>>> changing the license of the file.
>>
>> Ok.
>>
>>> And ISC, ick, why...  :)
>>
>> Because the license text in the other driver source files is a 1:1 match
>> with the ISC license.
> 
> Oh, I am not disagreeing with that, yes, that is obviously the license
> of the files. Just complaining about that choice for Linux kernel code :)

I see.

>> Another option could be MIT license which is in the preferred folder.
>> Will have to consult our legal department about it though.
> 
> Hey, if your legal department is going to get asked this, why not just
> switch it to GPLv2?  That would make everything much simpler.

Hah. Because I already know the answer to that. ;-)

Regards,
Arend