Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp18325ybm; Mon, 20 May 2019 11:05:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwdJcqEpISUyJKOeu946Y7TASPN5TFOw6ksrhHCjvorj3mn6A1v5A8J8vdFlChsIYxabP+4 X-Received: by 2002:a17:902:758b:: with SMTP id j11mr19605218pll.191.1558375515209; Mon, 20 May 2019 11:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558375515; cv=none; d=google.com; s=arc-20160816; b=Fj4x22McYbtaXZ3QJSqPpu0lyc2oxb4x8QcJ2QYvg3r8YNG3iDO1D+dwXb/0yx08tA kjV8Lx8Gu+Fe6GdNrbAyTdYbwi/fK6CiaiH8iSnFwjJt15HRIGGCyaVA7QopVOe79Sjt 8ByNRtL4gs74L8SIriCPmZabNkIFn6MI6wgkapWoF3a4Yk2RR5RlQqiOuHCSPecBhpOm fNZoYvDTpj/qGawYSW4dkdru/fhVdUxXCbJV5QfNpUhbcS+yiewi9WH8CfXZQ8zt2jef 1MP0DuyRPz0QaF+FEAfhc3VHS85J0fH/yQzpA2Bv8o8ycrEj8xNlLtbRCPlQk0Q6GJ/4 j9sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature; bh=4WcRCTJ8GqWBgKNEbRfX7yApJhlunqtSR8x26E26TZk=; b=B4u9Wwvi6ITynPFp1tYZkbo1+TeUiZQMgTpfma/dRbYTDHvfYQjwjgY8YKgk/nwfZR /0m8iEtEYBnBgySJDDKzD5hJp09D2/FNKb3fi04aqPS4VyARZigLOu/1Yw0c2fUoYjir CrOKosyTXEXHdo9M0UmfTLCvDm3krhuxrwW0s+pyf8qRvxgDe3NPT84x5bMNAXZs7yfS Wd8MtowidGCZ+OS4VnAx+vDLYMlIWXL//+/Lsu8qtrS7W63fTGRgZwZvh7MvziQ+6kjA zPAgdvjQzbArtZDM9sHBb73jSuS1Lf2sI6ixXuqLTrIAibwptjlHjdwtL6rXrzC3o4a3 vLRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=JKcQyElw; dkim=pass header.i=@codeaurora.org header.s=default header.b=QyI6EFyC; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si19442003pli.338.2019.05.20.11.04.59; Mon, 20 May 2019 11:05:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=JKcQyElw; dkim=pass header.i=@codeaurora.org header.s=default header.b=QyI6EFyC; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731361AbfETN44 (ORCPT + 99 others); Mon, 20 May 2019 09:56:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34472 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728000AbfETN44 (ORCPT ); Mon, 20 May 2019 09:56:56 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0A489611CE; Mon, 20 May 2019 13:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558360615; bh=lpzkQhinW+CdE25UU6vfCZ3VEc/mSbUJunMa0yH8T5s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JKcQyElwaI7wbLWVWImvpOnu1joBYw36xjYUSudFiD/noouYIcZAWqsMlhryKlHCV NMqcsgqxzME6wQFvfapbWpFwAO1bHN2TJpTD6gkH6t1z3PU7Ir9/r7t7rG0SsL9w75 DOvDrJLxv1FMdkN3uUzoHdAhxitbmqF/KpTY1dWk= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 9A6B2608D4; Mon, 20 May 2019 13:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558360612; bh=lpzkQhinW+CdE25UU6vfCZ3VEc/mSbUJunMa0yH8T5s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QyI6EFyC2jURPnStsICFWd1yeggqoqz7a/uzXQharivrl+6S5tQnXKzUTdIoyjzwE nbec4VFr4oDvh18pVKeVYKMF11riOvCKmSspPU/L74D627/AV0zDcUWAdGLIo54ylW kovjqkPyga01sCJMqy9EvSLStnHAAkgPMoiHC+Hc= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 20 May 2019 21:56:52 +0800 From: Yibo Zhao To: Johannes Berg Cc: Ben Greear , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Zhi Chen Subject: Re: [PATCH v2] mac80211: remove warning message In-Reply-To: References: <1557824507-17668-1-git-send-email-yiboz@codeaurora.org> <7c92f5cf51eaec1d5449698d90f5b6c5ca6c2bea.camel@sipsolutions.net> <34f72d5db336b9898618bf1c5c15ec41094d7d06.camel@perches.com> <4d013893-3302-14f0-c957-b3771f4b6b82@candelatech.com> <8eacb8e107c854b64a0c6116fca9731ddd99dcac.camel@sipsolutions.net> <730d3664-488d-7d57-04d5-1a57e91fa070@candelatech.com> Message-ID: X-Sender: yiboz@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-05-15 02:57, Johannes Berg wrote: > On Tue, 2019-05-14 at 11:54 -0700, Ben Greear wrote: >> >> Here is the info I have in my commit that changed this to >> WARN_ON_ONCE. >> I never posted it because I had to hack ath10k to get to this state, >> so maybe >> this is not a valid case to debug. >> >> >> Maybe Yibo Zhao has a better example. >> >> mac80211: don't spam kernel logs when chantx is null. >> >> I set up ath10k to be chandef based again in order to test >> WDS. My WDS stations are not very functional yet, and >> when ethtool stats are queried, there is a WARN_ON splat >> generated. Change this to WARN_ON_ONCE so that there is >> less kernel spam. > > I'm totally fine with WARN_ON_ONCE, FWIW. > > Sounds like different bugs though. You're talking about WDS here, and > Yibo was talking about something with AP interfaces prematurely > accepting frames or so. Yes, they might be different bugs that hit the same point. Looks like others found this too many warnings issue as well. Then I believe WARN_ON_ONCE() seems to be our solution for now. > > johannes -- Yibo