Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp311513ybi; Wed, 29 May 2019 22:02:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqT8Z1QPnAGtUxffzZ6ByUM+R9QOgNjIKYWsoFF8hPEZKUjVFiLiUI9SRgwU0tlPy8Cwqb X-Received: by 2002:aa7:86c3:: with SMTP id h3mr1815079pfo.169.1559192536001; Wed, 29 May 2019 22:02:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559192535; cv=none; d=google.com; s=arc-20160816; b=PThSuDyMvUdaB2LXZPRPIJ54RF1MqU2NlfxSyd0EHtCYg3KIwehPdn611xeh7xvhr7 bQihGZimlRaNzsGrgG7Sw0jAWWbX7cDamaoDsAuJKPg35gq+N83aCzy4DG8L81ZOuL2V r55Z1yyq1MiUjIK565KxoN5Yn9BJABxLurXD+aNgHOwevtiw0kq6sQdoOTBqEK8ALMoh fmsoQAra56etfl6Zfvv6fqRwMzCvatvNURzxQj4Utd7wCWWdcbzz1tRx2r2bCqkc7yPU K1utLdeloB3/EOOLz2J2YRCsYfmqEHSz33qKeyCuk107yheT1C0VC+mHwID0v3Zn7nmg ePDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=BuypNjUSZghaISVakxqW6xoLTmb84DdkajeJub7FK8c=; b=zbCXz7EtJ5BZ1Bm8pGwynBr8umkoGJJJ29cr42q4vN3Lr8qVyVOFUr29lVuQQWSBBS aauNgy3I8+tZZDr2MBs1xLNs3dGgGKZNRqO+1Aswi0sxGecABxHVtuCwbFCIKmm0GDs2 ovrKRW0r+Cpqgqga6F30U1ya1qgQgMepKyozxot9obQbAfCvqbEUPCWOnQYZ/DKOca84 Cs+KOfvPySFkKsz93vzPj7eJ/6XqkZHhp3KzK4VT30sWaTMF6rxv4BmiJpUfOlZffaAy ycihBev9wLOLJeWWyprS8IBeo8i7tKY6jsorJFRPbb/0jAmGmYkiOQFzFiMdRzUDcTRx C76g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="aQPI2/sr"; dkim=pass header.i=@codeaurora.org header.s=default header.b=MEaxeEnm; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i195si2432594pfe.20.2019.05.29.22.01.59; Wed, 29 May 2019 22:02:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="aQPI2/sr"; dkim=pass header.i=@codeaurora.org header.s=default header.b=MEaxeEnm; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389201AbfE3E7k (ORCPT + 99 others); Thu, 30 May 2019 00:59:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53164 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727672AbfE3E7j (ORCPT ); Thu, 30 May 2019 00:59:39 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A411D60213; Thu, 30 May 2019 04:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559192378; bh=1SgeDXWgbQ0KV936oxZHawpgAwsFnvw+M3W5urT1mUI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aQPI2/srpN6qewMq/vZqieIC8Iux3YhEbmlCENYLEtm5Dtk/G1q0WHBiv8gWU9tty Wf7IFgWOF14DK3jvM+AbU0AzWYQFJ9IEMX7gLVGEsbfSvxfOXrY0IqqYwx7ebsA4up KthpFNVVYQe6kgFKJjjNPjAXvgrQRpSY0F6rfs+k= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 50C7E60213; Thu, 30 May 2019 04:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559192377; bh=1SgeDXWgbQ0KV936oxZHawpgAwsFnvw+M3W5urT1mUI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MEaxeEnmed/F3fSESFGAbuuwZNg6hk+iTPitU1xNS/BSlPLSAZahGF5vpPitJ05Sz sCPPWy4LRUM7N3SVDrlpUcyYMN2hVlq2IUkkW8+nK0ExY1j0tagnSnbrEiNQ7rhRGY YDrnStmCsLc8NChvqOT5pSx9B7W9xBHMUSnOxvX0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 50C7E60213 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Tony Chuang Cc: Larry Finger , "linux-wireless\@vger.kernel.org" Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting routines References: <1559116487-5244-1-git-send-email-yhchuang@realtek.com> <1559116487-5244-2-git-send-email-yhchuang@realtek.com> Date: Thu, 30 May 2019 07:59:34 +0300 In-Reply-To: (Tony Chuang's message of "Thu, 30 May 2019 02:29:10 +0000") Message-ID: <87v9xspmfd.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tony Chuang writes: >> -----Original Message----- >> From: Larry Finger [mailto:larry.finger@gmail.com] On Behalf Of Larry Finger >> Sent: Wednesday, May 29, 2019 11:17 PM >> To: Tony Chuang; kvalo@codeaurora.org >> Cc: linux-wireless@vger.kernel.org >> Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting routines >> >> On 5/29/19 2:54 AM, yhchuang@realtek.com wrote: >> > From: Yan-Hsuan Chuang >> > >> > Some functions that should be static are unnecessarily exposed, remove >> > their declaration in header file phy.h. >> > >> > After resolving their declaration order, they can be declared as static. >> > So this commit changes nothing except the order and marking them static. >> > >> > Signed-off-by: Yan-Hsuan Chuang >> >> This patch does not apply. Using quilt to see what is wrong, there are 6 >> changes >> that have already been applied. >> >> Larry >> > > > These patches are based on > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-drivers > branch master > > commit 6aca09771db4277a78853d6ac680d8d5f0d915e3 > Author: YueHaibing > Date: Sat May 4 18:32:24 2019 +0800 > > rtw88: Make some symbols static > > > It should apply, did I miss something? I keep the bar high and take to wireless-drivers only patches which fix important, user visible problems. Everything else goes to wireless-drivers-next. So you should use wireless-drivers-next as the baseline for all regular patches. -- Kalle Valo