Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ganapathi Bhat <gbhat@marvell.com>
To:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC:     Cathy Luo <cluo@marvell.com>, Zhiyuan Yang <yangzy@marvell.com>,
        James Cao <jcao@marvell.com>,
        Rakesh Parmar <rakeshp@marvell.com>,
        Sharvari Harisangam <sharvari@marvell.com>
Subject: RE: [PATCH 2/2] mwifiex: add support for WIPHY_WOWLAN_ANY
Thread-Topic: [PATCH 2/2] mwifiex: add support for WIPHY_WOWLAN_ANY
Thread-Index: AQHVFs1/8zyTkymwpkCT7xicipVzuqaDcCtw
Date:   Thu, 30 May 2019 10:03:46 +0000
Message-ID: <MN2PR18MB2637696EA96F4EDB41C41319A0180@MN2PR18MB2637.namprd18.prod.outlook.com>
References: <1559209955-10089-1-git-send-email-gbhat@marvell.com>
 <1559209955-10089-2-git-send-email-gbhat@marvell.com>
In-Reply-To: <1559209955-10089-2-git-send-email-gbhat@marvell.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d929c320-4234-49c5-8f3d-08d6e4e61ae0
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2019 10:03:46.3439
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gbhat@marvell.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3104
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-30_05:,,
 signatures=0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Kalle,

Below is the second patch in the series; Kindly help to merge both;

Regards,
Ganapathi
> -----Original Message-----
> From: Ganapathi Bhat <gbhat@marvell.com>
> Sent: Thursday, May 30, 2019 3:23 PM
> To: linux-wireless@vger.kernel.org
> Cc: Cathy Luo <cluo@marvell.com>; Zhiyuan Yang <yangzy@marvell.com>;
> James Cao <jcao@marvell.com>; Rakesh Parmar <rakeshp@marvell.com>;
> Sharvari Harisangam <sharvari@marvell.com>; Ganapathi Bhat
> <gbhat@marvell.com>
> Subject: [PATCH 2/2] mwifiex: add support for WIPHY_WOWLAN_ANY
>=20
> From: Sharvari Harisangam <sharvari@marvell.com>
>=20
> Advertise support for WIPHY_WOWLAN_ANY trigger. Update default
> hostsleep condition to handle magic packet.
>=20
> Signed-off-by: Sharvari Harisangam <sharvari@marvell.com>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
> ---
>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 +++---
>  drivers/net/wireless/marvell/mwifiex/fw.h       | 4 +++-
>  2 files changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index e11a4bb..f23bb9c 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -3492,7 +3492,7 @@ static int mwifiex_cfg80211_suspend(struct wiphy
> *wiphy,
>  						  wowlan->nd_config);
>  	}
>=20
> -	if (wowlan->disconnect) {
> +	if (wowlan->disconnect || wowlan->any || wowlan->magic_pkt) {
>  		hs_cfg.conditions |=3D HS_CFG_COND_MAC_EVENT;
>  		mwifiex_dbg(sta_priv->adapter, INFO, "Wake on device
> disconnect\n");
>  	}
> @@ -4232,7 +4232,7 @@ static int mwifiex_tm_cmd(struct wiphy *wiphy,
> struct wireless_dev *wdev,  static const struct wiphy_wowlan_support
> mwifiex_wowlan_support =3D {
>  	.flags =3D WIPHY_WOWLAN_MAGIC_PKT |
> WIPHY_WOWLAN_DISCONNECT |
>  		WIPHY_WOWLAN_NET_DETECT |
> WIPHY_WOWLAN_SUPPORTS_GTK_REKEY |
> -		WIPHY_WOWLAN_GTK_REKEY_FAILURE,
> +		WIPHY_WOWLAN_GTK_REKEY_FAILURE |
> WIPHY_WOWLAN_ANY,
>  	.n_patterns =3D MWIFIEX_MEF_MAX_FILTERS,
>  	.pattern_min_len =3D 1,
>  	.pattern_max_len =3D MWIFIEX_MAX_PATTERN_LEN, @@ -4242,7
> +4242,7 @@ static int mwifiex_tm_cmd(struct wiphy *wiphy, struct
> wireless_dev *wdev,
>=20
>  static const struct wiphy_wowlan_support
> mwifiex_wowlan_support_no_gtk =3D {
>  	.flags =3D WIPHY_WOWLAN_MAGIC_PKT |
> WIPHY_WOWLAN_DISCONNECT |
> -		 WIPHY_WOWLAN_NET_DETECT,
> +		 WIPHY_WOWLAN_NET_DETECT | WIPHY_WOWLAN_ANY,
>  	.n_patterns =3D MWIFIEX_MEF_MAX_FILTERS,
>  	.pattern_min_len =3D 1,
>  	.pattern_max_len =3D MWIFIEX_MAX_PATTERN_LEN, diff --git
> a/drivers/net/wireless/marvell/mwifiex/fw.h
> b/drivers/net/wireless/marvell/mwifiex/fw.h
> index b73f99d..ad34b25 100644
> --- a/drivers/net/wireless/marvell/mwifiex/fw.h
> +++ b/drivers/net/wireless/marvell/mwifiex/fw.h
> @@ -478,7 +478,9 @@ enum mwifiex_channel_flags {
>  #define HostCmd_SCAN_RADIO_TYPE_A           1
>=20
>  #define HS_CFG_CANCEL			0xffffffff
> -#define HS_CFG_COND_DEF			0x00000000
> +#define HS_CFG_COND_DEF		(HS_CFG_COND_BROADCAST_DATA
> |\
> +				 HS_CFG_COND_UNICAST_DATA |\
> +				 HS_CFG_COND_MULTICAST_DATA)
>  #define HS_CFG_GPIO_DEF			0xff
>  #define HS_CFG_GAP_DEF			0xff
>  #define HS_CFG_COND_BROADCAST_DATA	0x00000001
> --
> 1.9.1