Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4242204ybi; Mon, 3 Jun 2019 07:50:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqz+QUdCTEK3E9QxtlfdeCLSbC0hswvTXnr3SccblyLFf7S0nryqJQb5hszOUxVz8SZT5XCH X-Received: by 2002:a65:44c8:: with SMTP id g8mr28737080pgs.443.1559573402225; Mon, 03 Jun 2019 07:50:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559573402; cv=none; d=google.com; s=arc-20160816; b=zNP4NViyUsQ3VZEubdEHi2Tx5pF1zERFUqokKKgE3BNoF4KTor/8p1RiLdE7y8EsBy mD9DByhE3cIg5819t3m/uwZLMKIwhOuYg/SXBRAguSeZBNAhvAZT9PNeBapLbiI7xEaL MBbovNNyDvP4OPh59DEIxqgpoeidQhmIikrbOGVfdDyUbXBR81PSTllScUc3o7Qc9BT9 YaVIkyGVU5A7RMar2yZzkl0ZqYbWy44+gkLpNm8brsQos7Fykf8hEDHTbTNfilMXpxPo uuAW9guutO8OWCuebffF6vJ0KgKYR2UGoeqnoZFdZNhtGoxxHJ0V+qS6O5fW704pKzH7 XTCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=NAP/mbGSAJ9ss9uojQG3mgS9NLchb9YgSJjUETg3h9s=; b=e2tGe0LxtYrhTLROkj8o430GWw+XlL8vL1OAAlSoV8BA4456SIt61Dyu1fvvOhCWc8 zSHLjsSQqngYhAw6y9edhTVmjMYO4KgZYQLw+2HaasnUQFOfVYLp45t7z7Jgi12NuCWp XuMZ4E2wETu5pIw1zWZZ1Zfn65Fgl+rxQVUEe8R6x/F/dBPypTFfRqZth0hYd1YElZJt XvM3hWve1yrmTamsSpUCI5MZl97VblkJtjcIedcq4h7me7lyQ6suxlcjFwp9sgcxAcAw TbpoF92phV7pLIQd8vl6EKJGffNB7DaR+G1rFetFSL7aPJwStCY5aDpmvXGQrViUOhKZ +cIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=pKmumP+l; dkim=pass header.i=@codeaurora.org header.s=default header.b="J38/2kwX"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20si17688283pgj.113.2019.06.03.07.49.39; Mon, 03 Jun 2019 07:50:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=pKmumP+l; dkim=pass header.i=@codeaurora.org header.s=default header.b="J38/2kwX"; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729120AbfFCOsa (ORCPT + 99 others); Mon, 3 Jun 2019 10:48:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38340 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727650AbfFCOsa (ORCPT ); Mon, 3 Jun 2019 10:48:30 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 65AD660252; Mon, 3 Jun 2019 14:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559573309; bh=4cZEGaj9UQufwOw+P10SLYwCO4sIdBPkTCOKNXaAYrU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pKmumP+lRXOqMs+XpnojsSc5mMFfAS5NN8gLBJoWy66a6s2PPmuUMpmfpEdFBhrwx zVBprnPVkHkZmMBZa16/8RoZUd30RdDI+sSQk/POJhxJ+HYyubcXuDNeMds1Vb/Vml 1BbTYfvR8bPYqXluXs0u8Z6dcLViK2rgLpu2k+6I= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C2F1460252; Mon, 3 Jun 2019 14:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559573308; bh=4cZEGaj9UQufwOw+P10SLYwCO4sIdBPkTCOKNXaAYrU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=J38/2kwXDfwSKhj+j4I0uBKwWafBspE+pcysiRe6q0bqMU2P3SObSe00nj3D/4LJ+ DYTd9FmwlIVklaQJ6xIXLrzztWhpQIQbmA+k+D6gg8J+0URDy/AtDTOFrtSyHhwMMq inIaa6I4b7lwFCeSGYQvVZKTiyABHFQF/cEeY6Ys= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C2F1460252 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Sven Eckelmann Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Sven Eckelmann , Sriram R Subject: Re: [PATCH] ath10k: avoid leaving .bss_info_changed prematurely References: <20190311083107.311-1-sven@narfation.org> Date: Mon, 03 Jun 2019 17:48:24 +0300 In-Reply-To: <20190311083107.311-1-sven@narfation.org> (Sven Eckelmann's message of "Mon, 11 Mar 2019 09:31:07 +0100") Message-ID: <878suiwwqv.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sven Eckelmann writes: > From: Sven Eckelmann > > ath10k_bss_info_changed() handles various events from the upper layers. It > parses the changed bitfield and then configures the driver/firmware > accordingly. Each detected event is handled in a separate scope which is > independent of each other - but in the same function. > > The commit f279294e9ee2 ("ath10k: add support for configuring management > packet rate") changed this behavior by returning from this function > prematurely when some precondition was not fulfilled. All new event > handlers added after the BSS_CHANGED_BASIC_RATES event handler would then > also be skipped. > > Signed-off-by: Sven Eckelmann > --- > Cc: Kalle Valo > Cc: Sriram R > > Only compile tested Unfortunately doesn't apply anymore, please rebase. Applying: ath10k: avoid leaving .bss_info_changed prematurely Using index info to reconstruct a base tree... M drivers/net/wireless/ath/ath10k/mac.c Falling back to patching base and 3-way merge... Auto-merging drivers/net/wireless/ath/ath10k/mac.c CONFLICT (content): Merge conflict in drivers/net/wireless/ath/ath10k/mac.c Recorded preimage for 'drivers/net/wireless/ath/ath10k/mac.c' error: Failed to merge in the changes. Patch failed at 0001 ath10k: avoid leaving .bss_info_changed prematurely -- Kalle Valo