Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Help with encrypting PMF management frames
From:   Ben Greear <greearb@candelatech.com>
To:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <fe571fe9-d5e5-38b8-5afa-2ba4fbb51f67@candelatech.com>
Organization: Candela Technologies
Message-ID: <bc99ae7e-ace3-94a4-03da-77db3698aadd@candelatech.com>
Date:   Thu, 6 Jun 2019 15:12:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <fe571fe9-d5e5-38b8-5afa-2ba4fbb51f67@candelatech.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 6/6/19 9:54 AM, Ben Greear wrote:
> Hello,
> 
> My variant of ath10k uses the normal 'native-wifi' tx path for management frames.
> Internally in the firmware, it seems that the management TID is flagged to expect
> raw frames, and I think that is why I see Action frames on-air that are not actually
> encrypted but which have some space added to their packet that should be filled in by
> the hw-crypt engine.
> 
> Is there a way to get mac80211 to software-crypt just management-tid PMF frames?
> 
> So far, I have not been able to find the correct place in the tx logic of
> mac80211...
> 
> Thanks,
> Ben
> 

Ok, I found the issue.  It seems the ath10k hardware refuses to encrypt
management frames unless they are sent in RAW mode (nwifi mgt frames are sent
w/out encryption for whatever reason).

So, the fix is in the ath10k driver (and just my driver I suppose, stock
driver uses a different API for mgt frames that eventually is raw-tx down in
the firmware).

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com