Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c3f982260cdf0749201f5535bf0f3bf9f6bfa7ba.camel@perches.com>
Subject: Re: [PATCH V2] iw: print HE capabilities
From:   Joe Perches <joe@perches.com>
To:     John Crispin <john@phrozen.org>,
        Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        Shashidhar Lakkavalli <slakkavalli@datto.com>
Date:   Thu, 06 Jun 2019 19:11:53 -0700
In-Reply-To: <20190528065828.25356-1-john@phrozen.org>
References: <20190528065828.25356-1-john@phrozen.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-05-28 at 08:58 +0200, John Crispin wrote:
> Print the HE MAC/PHY capabilities and MCS/NSS sets.

trivia:

> diff --git a/util.c b/util.c
[]
> +void print_he_info(struct nlattr *nl_iftype)
> +{
> +	struct nlattr *tb[NL80211_BAND_IFTYPE_ATTR_MAX + 1];
> +	struct nlattr *tb_flags[NL80211_IFTYPE_MAX + 1];
> +	char *iftypes[NUM_NL80211_IFTYPES] = {
> +		"Unspec", "Adhoc", "Station", "AP", "AP/VLAN", "WDS", "Monitor",
> +		"Mesh", "P2P/Client", "P2P/Go", "P2P/Device", "OCB", "NAN",
> +	};

Should probably be
	const char * const iftypes[...]