Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V2] iw: print HE capabilities
To:     Joe Perches <joe@perches.com>, John Crispin <john@phrozen.org>,
        Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        Shashidhar Lakkavalli <slakkavalli@datto.com>
References: <20190528065828.25356-1-john@phrozen.org>
 <c3f982260cdf0749201f5535bf0f3bf9f6bfa7ba.camel@perches.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <ffabd374-b0ff-1970-4b75-fbc6547fe5f1@broadcom.com>
Date:   Fri, 7 Jun 2019 09:22:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <c3f982260cdf0749201f5535bf0f3bf9f6bfa7ba.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 6/7/2019 4:11 AM, Joe Perches wrote:
> On Tue, 2019-05-28 at 08:58 +0200, John Crispin wrote:
>> Print the HE MAC/PHY capabilities and MCS/NSS sets.
> 
> trivia:
> 
>> diff --git a/util.c b/util.c
> []
>> +void print_he_info(struct nlattr *nl_iftype)
>> +{
>> +	struct nlattr *tb[NL80211_BAND_IFTYPE_ATTR_MAX + 1];
>> +	struct nlattr *tb_flags[NL80211_IFTYPE_MAX + 1];
>> +	char *iftypes[NUM_NL80211_IFTYPES] = {
>> +		"Unspec", "Adhoc", "Station", "AP", "AP/VLAN", "WDS", "Monitor",
>> +		"Mesh", "P2P/Client", "P2P/Go", "P2P/Device", "OCB", "NAN",
>> +	};
> 
> Should probably be
> 	const char * const iftypes[...]

We are doing this iftype string mapping in several places so a helper 
function may be warranted.

Gr. AvS