Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp519391ybi; Fri, 7 Jun 2019 11:55:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqxryRCKUbsi6u0XvQePK/iz5NccRS7XCCEI/+CrjyXTEJpyOFZ2jFVCo+W4ObiM7sho/fk2 X-Received: by 2002:a63:a056:: with SMTP id u22mr4380434pgn.318.1559933717211; Fri, 07 Jun 2019 11:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559933717; cv=none; d=google.com; s=arc-20160816; b=kc6D+UYuZM1vJILSzZQnxtVhy+OT9GDZoUDYEh3CGkThIjykkZke2qYFbpApmcpORk cEHiCuMi/IqRw7SOMmQFLVLet37DxWsu4zDqLFwmAcPBBek3MpTNSpkXU5M+8rQ3L7KZ lLqANKAELW5e8TrxQ6MmzK2/8wI+fP6jY6DUylD+T64kOuAyDexQ2xSWcP31mPTz3+7w JMZ1pqmBlPDXIYKRFiJsuK9BPHJdNOIFfJFZ9BKma2POEzng55XrQpIC/IULcIfm1g93 AeGxIHpMHoHCjo6/AMDtuJO5AWeE0FYlal0zZkYK3p8xY3RzqVJskc5wbzRWoqX/0vTz geFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=qvG1NrX14iwWdIJXUQBpSSBonW+vbEpNwYJBzzaE+Pw=; b=y037sPre/lQuTG1XOUMVoXbM/LtpDMc7OITEPRYtAbuO1ojMj1mNd1NNtUq4if7ROY ZiwXf+GEI8GOrYl0ikQW82BdkxJf6GuLst09WuXHRx1mWvGYcTmCrDFXIJl8kK7S26Kx OyCBopxIX3+YLPkRHNVSv9ze0XljBND70g+xSyzVgm72ZbbdL27XLA/akF9EUgqTJR1r SiwW+geC3Fxl1BXz7Kd6mTSiA5q7uyhhmeAlS3ZGzc+C4pc9jMpfCIGbd4i/rq6781D/ 3JeqfABiiGFykSUN/NvXclgeV/w941UZT/otK+F016u8CqfzRgV56HSJchT1y8VT9Nc1 7wiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=gLEqh8d4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13si2710844pgs.446.2019.06.07.11.55.02; Fri, 07 Jun 2019 11:55:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=gLEqh8d4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730828AbfFGRCi (ORCPT + 99 others); Fri, 7 Jun 2019 13:02:38 -0400 Received: from nbd.name ([46.4.11.11]:59474 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728989AbfFGRCh (ORCPT ); Fri, 7 Jun 2019 13:02:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qvG1NrX14iwWdIJXUQBpSSBonW+vbEpNwYJBzzaE+Pw=; b=gLEqh8d4XeAlkSQQUnM2UcPjMq AWOJqxOWv9CdR3OFrAgRnhR9tYK8tONVcNMv4wUPdUV13t368q2+uSpfTF4r/AhZPb4SWinxajv75 ugtNtqwy5hCPRFdb/274GC4PbtyM3WPHZxoflJlCkWLKDhrykmj8IJFMqqf4QjhUtbDU=; Received: from p4ff13bc7.dip0.t-ipconnect.de ([79.241.59.199] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hZIG9-00016r-QE; Fri, 07 Jun 2019 19:02:33 +0200 Subject: Re: [PATCH] mt76: mt7615: remove key check in mt7615_mcu_set_wtbl_key To: Lorenzo Bianconi Cc: lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org, ryder.lee@mediatek.com, royluo@google.com References: <51396ab29d290f95caecbb7fd817c654b74b36dc.1559686202.git.lorenzo@kernel.org> From: Felix Fietkau Openpgp: preference=signencrypt Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= mQGiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwbQcRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPohgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQuQINBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabiEkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: <75e3bc4e-e338-fbe2-1077-e59ec3fda8e4@nbd.name> Date: Fri, 7 Jun 2019 19:02:33 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <51396ab29d290f95caecbb7fd817c654b74b36dc.1559686202.git.lorenzo@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-06-05 00:12, Lorenzo Bianconi wrote: > Do not check key pointer in mt7615_mcu_set_wtbl_key since if set_key_cmd > is SET_KEY, key will be always not NULL. This patch will address a false > positive reported by Coverity-Scan > > Addresses-Coverity-ID: 1445463 ("Dereference after null check") > Signed-off-by: Lorenzo Bianconi Applied, thanks. - Felix