Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp520524ybi; Fri, 7 Jun 2019 11:56:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLtVOP5AqdW66tPE7Ebn6cUX2ivhXjkLBfZc6umVG4NqL+Mq3jbeaGbCrSIWIItqj5tx+k X-Received: by 2002:a17:90a:1b4a:: with SMTP id q68mr7445963pjq.61.1559933812431; Fri, 07 Jun 2019 11:56:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559933812; cv=none; d=google.com; s=arc-20160816; b=jlhCn5eIVtYTiAqatMBpKW2X/tXKYzvQvERfJ5d3+11szzb3U3otrLoWR7BTX6Qacf 9z279QM83cfIJz5HP6ddzMLLFVRIpcJE6FF/59NgbjoEGwTdtoTnWXJm54Fi720iHRzf Vm/1LZQkf3F529fJPbjTf4r0tlWxUzScGfsCHnOmdHV55EPPIUKBfM3qim+gANwoFtrE 1xFBgP6fXmmodNzqa4qActu7Kc+CHsD1sIZSu5IvP+BlPz2yVkv3bH6Vh501KMpKxu8E P/N1oh5ocujkxIQx5e499LMMgs3ScTE+7bP0RwfWP8Al7KmQfYNYSk89e8mrHe8rPCxg GNBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=e3iZ63G6yKwzAKDKbU2DZ2ZMaR+fsRqB1Caa8gq5EyI=; b=sy5mTTegy/iIQG28XcwkGUvWwFVNvdxxYoLfQGwXuFgy3C7584fidGxEyU/HnvKH1C gOaUC1Qc3f3ww3Bn2WXNlLA15EM8GPFxmHsMmBWAiTFE1k6Ycv/2a7o7L7OKmJ0Ubnyh nvO/KKzKUFMXvmS6sLVEApyurfcXiFMYsmOg/0PJl0I8pYMb2/0uru80f3apmaeu+UZy w6K3DSHQ+IK45HYC12JCF7ZJPdC55/hpXnyFOLR7YbnlEDs790xjCTHbWlECu12kp9wN BMBxQPhEy7+Z31rW9kJBxL6BJu73IiohgD/SfLNp+ltH2G6xenoG2f9cFAPOyYJOAL22 IIHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 102si3047621plf.250.2019.06.07.11.56.23; Fri, 07 Jun 2019 11:56:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730354AbfFGR3a (ORCPT + 99 others); Fri, 7 Jun 2019 13:29:30 -0400 Received: from verein.lst.de ([213.95.11.211]:57638 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729550AbfFGR3a (ORCPT ); Fri, 7 Jun 2019 13:29:30 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 2E5C868AFE; Fri, 7 Jun 2019 19:29:03 +0200 (CEST) Date: Fri, 7 Jun 2019 19:29:02 +0200 From: Christoph Hellwig To: Larry Finger Cc: Aaro Koskinen , Christoph Hellwig , Christian Zigotzky , Michael Ellerman , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook Message-ID: <20190607172902.GA8183@lst.de> References: <20190605225059.GA9953@darkstar.musicnaut.iki.fi> <73da300c-871c-77ac-8a3a-deac226743ef@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73da300c-871c-77ac-8a3a-deac226743ef@lwfinger.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org I don't think we should work around this in the driver, we need to fix it in the core. I'm curious why my previous patch didn't work. Can you throw in a few printks what failed? I.e. did dma_direct_supported return false? Did the actual allocation fail?