Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Christian Hewitt <christianshewitt@gmail.com>
Content-Type: text/plain;
        charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: [RESEND] brcmfmac support for BCM4359 sdio on arm64 ??
Message-Id: <F5C2858A-498E-4AD3-859D-FA9D14BF6B37@gmail.com>
Date:   Sat, 8 Jun 2019 07:39:24 +0400
Cc:     linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com, Wright.Feng@cypress.com,
        Neil Armstrong <narmstrong@baylibre.com>,
        Christoph Muellner <christoph.muellner@theobroma-systems.com>
To:     arend.vanspriel@broadcom.com
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hello Arend,

Last October Christoph M=C3=BCllner reported BCM4359 SDIO issues here: =
https://www.spinics.net/lists/linux-wireless/msg178783.html but the =
investigation stalled after the needs/timescale of his project forced a =
change to a different (working) module.

BCM4359 is being used in an increasing number of Amlogic devices the =
Kodi focussed distro LibreELEC supports. I=E2=80=99m one of the =
maintainers for the distro and I=E2=80=99d like to assist/resume the =
investigation.

To recap: using changes from Wright Feng that can be found here =
https://github.com/RobertCNelson/ti-linux-kernel-dev/blob/65f17112e1c883d3=
c9f3fa68837e5f9b5eb7cfad/patches/cypress/v4.14.52-2018_0928/cypress-patch/=
0050-brcmfmac-Add-support-for-BCM4359-SDIO-chipset.patch result in the =
BCM4359 device being identified but firmware/nvram loading fails:

[    8.557929] brcmfmac: F1 signature read @0x18000000=3D0x17294359
[    8.562087] brcmfmac: brcmf_fw_alloc_request: using =
brcm/brcmfmac4359-sdio for chip BCM4359/9
[    8.775655] brcmfmac: brcmf_sdiod_ramrw: membytes transfer failed
[    8.775667] brcmfmac: brcmf_sdio_verifymemory: error -84 on reading =
2048 membytes at 0x0025f0c0
[    8.775670] brcmfmac: brcmf_sdio_download_firmware: dongle nvram file =
download failed

See: http://ix.io/1KfY for the full dmesg output on 5.1-rc1 kernel =
including a splat that may or may not be related/relevant. I am using =
firmware and nvram files from =
https://github.com/LibreELEC/brcmfmac_sdio-firmware which match files =
found in several other github and public repo locations. The =
firmware/nvram are reported working in Android.=20

BCMDHD is also reported working with commits here: =
https://gitlab.com/baylibre/amlogic/atv/linux/commits/narmstrong/v5.1/aml/=
integ-5.1-bcmdhd but LibreELEC needs to support many different boards =
(with many different SDIO modules) from a single OS image, so BCMDHD is =
not the solution we need.

One additional patch I spotted mentioning BCM4359 (also from Wright =
Feng) was =
https://github.com/RobertCNelson/ti-linux-kernel-dev/blob/65f17112e1c883d3=
c9f3fa68837e5f9b5eb7cfad/patches/cypress/v4.14.52-2018_0928/cypress-patch/=
0073-non-upstream-reset-two-D11-cores-if-chip-has-two-D11.patch but it =
makes no difference (the dmesg log above is with this patch applied).

I don=E2=80=99t write code but am happy to build test kernels with =
suggested patches or explicit instructions. I=E2=80=99ve also CC=E2=80=99d=
 LibreELEC colleague and linux-amlogic maintainer Neil Armstrong who can =
assist. NB: If direct access to hardware would help progress things I =
can easily organise remote access or get board samples shipped.

How can we resume the investigation?

Christian