Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 9 Jun 2019 23:57:11 +0200
From:   Michael =?UTF-8?B?QsO8c2No?= <m@bues.ch>
To:     H Buus <ubuntu@hbuus.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        Michael Chan <michael.chan@broadcom.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Should b44_init lead to WARN_ON in
 drivers/ssb/driver_gpio.c:464?
Message-ID: <20190609235711.481bbac9@wiggum>
In-Reply-To: <946c86bf-7e90-a981-b9fc-757adb98adfa@hbuus.com>
References: <946c86bf-7e90-a981-b9fc-757adb98adfa@hbuus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/j1ztxFZ/t9QL4ize+KYtKmd"; protocol="application/pgp-signature"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

--Sig_/j1ztxFZ/t9QL4ize+KYtKmd
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Sun, 9 Jun 2019 17:44:10 -0400
H Buus <ubuntu@hbuus.com> wrote:

> I have an old 32 bit laptop with a BCM4401-B0 100Base-TX ethernet
> controller. For every kernel from 4.19-rc1 going forward, I get a
> warning and call trace within a few seconds of start up (see dmesg
> snippet below). I have traced it to a specific commit (see commit
> below). On the face of it, I would think it is a regression, but it
> doesn't seem to cause a problem, since networking over ethernet is workin=
g.


This warning is not a problem. The commit just exposes a warning, that
has always been there.
I suggest we just remove the WARN_ON from ssb_gpio_init and
ssb_gpio_unregister.
I don't see a reason to throw a warning in that case.

--=20
Michael

--Sig_/j1ztxFZ/t9QL4ize+KYtKmd
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAlz9gLcACgkQ9TK+HZCN
iw4SdA//ckBMesNtmeE5ovBdzE4mhaRf4sSBmN2DP1ctMil/nhW5nH7jF5jtvqxL
1RMT7aS5TZ1B+h50Y4rxpG4DFeyQCobaDaoHhqcbmXQp/zVRCOSbyb10zd/GC1q4
pZyxwgOc58pCNseGB7PMTiAmZCdxbhUkdjFRwuadTdQ0QqFEzWhO5IN+YdT80T4W
4htUP8ZDcQoQkjWF/tt/0bGuMrQaloqRzLDLP9C/gvZT4R1Uc3csh4rdaRHZCKQ1
OHxj47DYID03hf3tYnxg4JptWUPuEsZQHSX3Tw/Y5IFf0LdznTKbSMfqvS0qkdxF
d3U/ium0zqibJkeDcIpdUtWPPO353SMkaxYHV2KrWOnykG0cw9jhXevU+ZnmnAdy
swLVoHwsr1HWzTcUAbEZoUeY//7X1JWlqE8VH47Fsk5f/lePhdfCsfuU3JKEdcCt
ofgjpZbqR+8CY/rPMUxZ113vqLarFNNX6qaHYW0M35U7yu1SKw1wqpIFqwR8eXhN
AKwX46sLv/VTTM4MUb55PqdU90hyQS03e5215d8OowqnIvPwLqCJh2nFKJq5disk
nu19j2tPqrAyY5Q+2ts+BS6W3/aqZVrnK4OnJ+vyeYzE70dKgZ6MDYVyD1SzQhkZ
VehX4/NZ4XHVXOxaRnfRdnq5uTl56j50VUDbBQFDIT5tyau8ZCU=
=Br6O
-----END PGP SIGNATURE-----

--Sig_/j1ztxFZ/t9QL4ize+KYtKmd--