Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Jun 2019 09:56:24 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Sven Eckelmann <sven@narfation.org>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name,
        linux-wireless@vger.kernel.org, ryder.lee@mediatek.com,
        royluo@google.com
Subject: Re: [PATCH 1/2] mt76: mt7615: init per-channel target power
Message-ID: <20190611075623.GA3091@localhost.localdomain>
References: <cover.1560234876.git.lorenzo@kernel.org>
 <ade300b855949dcbe0a278e363415bd56b2e1299.1560234877.git.lorenzo@kernel.org>
 <3556594.76tU91ddA5@bentobox>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24"
Content-Disposition: inline
In-Reply-To: <3556594.76tU91ddA5@bentobox>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--u3/rZRmxL6MmkK24
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Tuesday, 11 June 2019 08:38:52 CEST Lorenzo Bianconi wrote:
> > +               switch (n_chains) {
> > +               case 4:
> > +                       target_power +=3D 6;
> > +                       break;
> > +               case 3:
> > +                       target_power +=3D 4;
> > +                       break;
> > +               case 2:
> > +                       target_power +=3D 3;
> > +                       break;
> > +               default:
> > +                       break;
> > +               }
>=20
> Any reason why you use different value for 3 chains than ath9k? Following=
=20
> values are used in ath9k:
>=20
> * 1 chain: 0 dB
> * 2 chains: 3 dB (max combined gain ~3.010299956639812 dB)
> * 3 chains: 5 dB (max combined gain ~4.771212547196624 dB)

Hi Sven,

I just rounded down the values, but we can use 5db (in this case we need to=
 fix
it even in mt76_get_power(), so I will do it in a different patch)

Regards,
Lorenzo

> * 4 chains: not supported (max combined gain 6.020599913279624 dB)
>=20
> Here are the definitions from ath9k (values are saved in .5 dB steps)
>=20
>     drivers/net/wireless/ath/ath9k/eeprom.h:#define POWER_CORRECTION_FOR_=
TWO_CHAIN          6  /* 10*log10(2)*2 */
>     drivers/net/wireless/ath/ath9k/eeprom.h:#define POWER_CORRECTION_FOR_=
THREE_CHAIN        10 /* 10*log10(3)*2 */
>=20
> Kind regards,
> 	Sven


--u3/rZRmxL6MmkK24
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXP9epAAKCRA6cBh0uS2t
rDXPAP4pZ7vUcobJhIskAId9K6En7k46IcTRktvEpTxHwI0NOgEAr4sY3igEDBiY
Bbo+CvCvLwA9aQItZ7964BIboDMHTQg=
=kTax
-----END PGP SIGNATURE-----

--u3/rZRmxL6MmkK24--