Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4464000ybi; Tue, 11 Jun 2019 07:06:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJQ14362UJDiUT21mQhXU6iLWCN08tT9HBvVYKJRTzvNzC+rRaWWiKkqwaRkMMDKMpLdEv X-Received: by 2002:aa7:82d7:: with SMTP id f23mr79164443pfn.138.1560262010943; Tue, 11 Jun 2019 07:06:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560262010; cv=none; d=google.com; s=arc-20160816; b=v95CXkQITNfw1hIPb9aSMVbpt97NmJu4+/R1ZyD0Eq21wag4O+NAfy4ijyfwx3bd6C PQ4rV+1qjgpBGvGYQ80tUWGmrY37AA3OolQASyzntHHMPnLdxLE4hPvyFQ0GIoN1CRsH GtZp27RSTEDen7jHvdrX8tUSdM4fFxaUw2PYMd0FKnyNWR0eLCgajj8SkcwG6jmFzleY EGtL3F/bWtWwHm55RkZZB5LvYBwDBQgAcGAr8RQ8ekmdjwfUSNgeHL/0RtCognNwzTBo bFQfMC/Zt2flMpHNBBK+OYQVQJtD3ksU2NIXuKkC6oxHH8ltv6ibdujZt2lZ4Et2XH1x 46wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=OdhVQm7ebtQwBjyyMILB5MoC2avje8h/he6OJPy1E0o=; b=uUjqz4lEKYVofTvCRmtA3K0ATcM9LLG4q0oxSD3DHBV+MobLfGlvx3OFuGc3DMX8bU v0+UG0PRBAZYMNiq9OlIBMdUweMQ9AptkwN3hFMnRibhNBiM/VvP0XDgXpdwoAi+lkC5 4N2pnKd+zg9swkz0+5ipQZQYArbTCum34j3R/J02KkBd4ubQlSFK8K1FKc/IhBlLhUKO DIeoM5p3GsZXSGRwSF0K0cHnYYcGNhxlR1vgywaEhXAQm5SnUd24PQbVforn3h+Kum2n XrBy4IyYGeBb0+Q+eUHOjOYxUV9cG+2+dzYbPw7LKlXpOyevus4wLUGizY4egQYsqmiL JWtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=gprOqQkZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=gprOqQkZ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v13si6970646pgr.282.2019.06.11.07.06.30; Tue, 11 Jun 2019 07:06:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=gprOqQkZ; dkim=pass header.i=@codeaurora.org header.s=default header.b=gprOqQkZ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391253AbfFKNni (ORCPT + 99 others); Tue, 11 Jun 2019 09:43:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38338 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387770AbfFKNnh (ORCPT ); Tue, 11 Jun 2019 09:43:37 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 64566602F3; Tue, 11 Jun 2019 13:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560260617; bh=W42Jjl6olvpcRbE4JrwKtXyWc4LDnzFTCCCaEZTqzqY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gprOqQkZIsGTfTBb4ISiQuuBFYLQaHYT8j/BMhk61BqKujUH7tItjK6XOmlqcn7A/ eBu3Pf0BiApu4lReI+nbWpp7egKBT8by3mifKySvSvBOoP6jPRBwGLR+xVtGRpcF3J WQoC9kufBd8x/zepgBFazgXbAOU5qUkHuLD6S/Fg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0B0F7605A5; Tue, 11 Jun 2019 13:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560260617; bh=W42Jjl6olvpcRbE4JrwKtXyWc4LDnzFTCCCaEZTqzqY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gprOqQkZIsGTfTBb4ISiQuuBFYLQaHYT8j/BMhk61BqKujUH7tItjK6XOmlqcn7A/ eBu3Pf0BiApu4lReI+nbWpp7egKBT8by3mifKySvSvBOoP6jPRBwGLR+xVtGRpcF3J WQoC9kufBd8x/zepgBFazgXbAOU5qUkHuLD6S/Fg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0B0F7605A5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Zefir Kurtisi Cc: linux-wireless@vger.kernel.org, nbd@nbd.name Subject: Re: [PATCH v2] ath9k: correctly handle short radar pulses (fixes 3c0efb745a) References: <20190611131006.29715-1-zefir.kurtisi@neratec.com> <20190611133656.16964-1-zefir.kurtisi@neratec.com> Date: Tue, 11 Jun 2019 16:43:33 +0300 In-Reply-To: <20190611133656.16964-1-zefir.kurtisi@neratec.com> (Zefir Kurtisi's message of "Tue, 11 Jun 2019 15:36:56 +0200") Message-ID: <87h88wgrui.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Zefir Kurtisi writes: > Changes to v1: > * typos fixed in commit-message > -- > > In commit '3c0efb745a17 ("ath9k: discard undersized packets")' > the lower bound of RX packets was set to 10 (min ACK size) to > filter those that would otherwise be treated as invalid at > mac80211. > > Alas, short radar pulses are reported as PHY_ERROR frames > with length set to 3. Therefore their detection stopped > working after that commit. > > NOTE: ath9k drivers built thereafter will not pass DFS > certification. > > This extends the criteria for short packets to explicitly > handle PHY_ERROR frames. > > Signed-off-by: Zefir Kurtisi Forgot to mention that the Fixes line should be before s-o-b, not in the title: Fixes: 3c0efb745a17 ("ath9k: discard undersized packets") I'll fix (no pun intended) that as well. -- Kalle Valo