Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5728817ybi; Wed, 12 Jun 2019 07:30:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYktPMBhzkip4rIP1rv+bKoiEFoxiR/PcSX7wPOI2m8GhDp9n4loE8X/BXsOdHlwgKioHw X-Received: by 2002:a17:902:848b:: with SMTP id c11mr59502362plo.217.1560349823068; Wed, 12 Jun 2019 07:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560349823; cv=none; d=google.com; s=arc-20160816; b=lRBQ7kKNQAfuJn/71lf3EpliPrFfL9KtfYJzrj1KdvY0x88vBhp8tfR7ly2RkfTE6e Y/7mp8gvtl+VreWJzIJ32h6jbGqLFcwUe/l93Gfc7JBLLJPbReKmvKTQeQ/dHuIuJNop UASdwlf9Ojx3cxzrt31ZY8/heR77NadRo9UgXVpbMi8b03qFZgXYAec+A7MWaJq5IUBY tQ60pL5ubIh7OsZaNmLX6oItVkVqBakYuiymeo8hf27TdXRCmOs4SsYtQUZB7RKEbVwf CoxsZhxpPsAf8mF+a9n0K+EbIHHVMrn6+YFqok8ODDef2NtKa5nH+gt1p3m87gg2L/UO 7kng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=D3KAVVTAWt6DnfE0BbrqHkFwK+WBtlR0Q2h//GrtyWw=; b=syUQ0jGUncveIYrXbpngpSyB1YlgLqaKxXWoW5HTAHv1/yPgryApT5u346SsCNjH6s 41auZ/NW/0aAtRRIwrypOXYWSbiEF/sVh2C+7nNgZ/hssvMNNgg2bTXjkYYE0SVoC/2E CeGhNE5/pP7n5Tgs37kahGXBPRQwkF/SnDPR/lQXm2nLXzP5KBOsWFZ5dv3d+AkR7Z6b UBvdkUrohCUaHSFrMUdMweNiIgNJQeXALqq+Gxt+Ukp8WnjWckRFrPhsb3fBFY1b8jYd byJIOsV+2Xy+Ys2ySMSQu/5V+x2xrzWwcNDmfXSgGfgsM9UP1jZtnaCrkfAtMh6cxhTH pEqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Hsygi9Ou; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w15si12073806pll.173.2019.06.12.07.30.01; Wed, 12 Jun 2019 07:30:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Hsygi9Ou; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407412AbfFLKHU (ORCPT + 99 others); Wed, 12 Jun 2019 06:07:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:58966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405946AbfFLKHU (ORCPT ); Wed, 12 Jun 2019 06:07:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 486A22080A; Wed, 12 Jun 2019 10:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560334039; bh=Z0uFGeIYb8NOCYuMjBbf2vGG/B/zrmYzY6IbKTW5PuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hsygi9Ouhowtd80jDBfZMIFp2HBWyjceyODdZKcUaH5kE3NwpTtenD0Mm6GUm9FN+ 0q6Kn9vtxWzaqK/bOOvpEOyM1pB4lhLrD8vJS4FyORGsx/1nj1J/qc12ElUOZNRCLS Q8iksG83usxRGq1o56wF+1ZcxL7KiSJOM6b2kX58= Date: Wed, 12 Jun 2019 12:07:17 +0200 From: Greg Kroah-Hartman To: Maya Erez , Kalle Valo Cc: "David S. Miller" , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com Subject: Re: [PATCH] wireless: wil6210: no need to check return value of debugfs_create functions Message-ID: <20190612100717.GA19167@kroah.com> References: <20190611191024.GA17227@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611191024.GA17227@kroah.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Jun 11, 2019 at 09:10:24PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Maya Erez > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wireless@vger.kernel.org > Cc: wil6210@qti.qualcomm.com > Signed-off-by: Greg Kroah-Hartman > --- > drivers/net/wireless/ath/wil6210/debugfs.c | 80 ++++++---------------- > 1 file changed, 22 insertions(+), 58 deletions(-) Oops, 0-day finally woke up and shows I messed this patch up. Please drop it, I will submit a v2 soon. thanks, greg k-h