Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DF0C460213
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Nathan Huckleberry <nhuck@google.com>
Cc:     eliad@wizery.com, davem@davemloft.net, netdev@vger.kernel.org,
        linux-wireless@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c
References: <CAJkfWY4WkeMv3Z+Nh4B0xtErTAi6mVCriURZTjd2Q__gMtaEqA@mail.gmail.com>
Date:   Fri, 14 Jun 2019 08:25:56 +0300
In-Reply-To: <CAJkfWY4WkeMv3Z+Nh4B0xtErTAi6mVCriURZTjd2Q__gMtaEqA@mail.gmail.com>
        (Nathan Huckleberry's message of "Thu, 13 Jun 2019 11:00:33 -0700")
Message-ID: <874l4slouz.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Nathan Huckleberry <nhuck@google.com> writes:

> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There are two unused variables ('wl18xx_iface_ap_cl_limits' and
> 'wl18xx_iface_ap_go_limits') in drivers/net/wireless/ti/wl18xx/main.c.
> These appear to be limits when using p2p devices, yet they are never
> used.
>
> Wanted to reach out for the best course of action to fix the warning.
>
> https://github.com/ClangBuiltLinux/linux/issues/530

The the variables were added in this commit:

commit 7845af35e0deeb7537de759ebc69d6395d4123bf
Author:     Eliad Peller <eliad@wizery.com>
AuthorDate: Thu Jul 30 22:38:22 2015 +0300
Commit:     Kalle Valo <kvalo@codeaurora.org>
CommitDate: Mon Aug 10 22:16:34 2015 +0300

    wlcore: add p2p device support

And even that commit didn't use them, no idea why. Just send a patch
removing them, if someone needs them later they can be added again.

-- 
Kalle Valo