Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1248371ybi; Sun, 16 Jun 2019 00:35:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyzGuadKWovZhdOnJEhFotGXyomO9vZ1yVsKTjGOSajce6CqCOZmsu2XvkFf+NLbQq99nhN X-Received: by 2002:a17:902:778d:: with SMTP id o13mr51317903pll.82.1560670508507; Sun, 16 Jun 2019 00:35:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560670508; cv=none; d=google.com; s=arc-20160816; b=EIHkzyZMoa2L9miiywySW5Kq3/miO7PA+a9E+k2dkw4kkZtDVyq+I6Ifav8N0yCxlC Hmfij6PhD7Y+ITqyqqPbuFuHFXm8tUqqbEtU061MHXvr5zyVXV64ErVcVBGd6A+udPXZ AuIWu+aIntt8sfmEvvguY3jwI/1BQskhX46FH30Bggh/2uhZNAOgV+x+amCnozgRiTNB Kl9OAjWttdweJ3wcsC8c5aFdwJyYHZH+18sqUA8iMyfS3MqxJtH8gLJzaWJv1cblHQAg n9oZ6KR8ir62d0hav2/2r2RYTl71QWyph1bPPODl1R185LFwdWasd9x+YkRc0vpfZFNc bAvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=mboLxtPCL9SBOKa5a6qJ7CU7wcACqyr+s56hf2j/VBM=; b=JIRJG2S+lsvRyBq/1p1hJGU527S4jtrWMXeBn0LL7Y84sA6ImM+Ty26aZZYH5ps3ZH ZFmRtNNkdpMZJtGSQBKmlj2ojKjHyd6n58AvzDIVqCpIxFAcRCx50cqDOKMdwwM4zo5A Rt1OiVW8/w0hSQzBCCktmpSoz69LqnuMJk3dCykQlR9vVxdtJ0sI+FkOY0r/qGwMAtJP +6C8WsYdb6GnZZ46EYnDjsKUuPaBgas10k0dwNM7AUMwvV/pT6VHWSUZ1b5HxRWovrui cyFYFuT/qubMP0mo+PcWzjkLJAaCa542uD+/8wXSF5LaynwQe9f34Cb8C9B9JdI39VqL sAaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s10si6788308plq.129.2019.06.16.00.34.54; Sun, 16 Jun 2019 00:35:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbfFPHeV (ORCPT + 99 others); Sun, 16 Jun 2019 03:34:21 -0400 Received: from alexa-out-ams-02.qualcomm.com ([185.23.61.163]:27491 "EHLO alexa-out-ams-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbfFPHeU (ORCPT ); Sun, 16 Jun 2019 03:34:20 -0400 Received: from ironmsg02-ams.qualcomm.com ([10.251.56.3]) by alexa-out-ams-02.qualcomm.com with ESMTP; 16 Jun 2019 09:26:14 +0200 X-IronPort-AV: E=McAfee;i="6000,8403,9289"; a="8499835" Received: from lx-merez1.mea.qualcomm.com ([10.18.173.103]) by ironmsg02-ams.qualcomm.com with ESMTP; 16 Jun 2019 09:26:12 +0200 From: Maya Erez To: Kalle Valo Cc: Dedy Lansky , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, Maya Erez Subject: [PATCH 05/11] wil6210: fix printout in wil_read_pmccfg Date: Sun, 16 Jun 2019 10:26:01 +0300 Message-Id: <1560669967-23706-6-git-send-email-merez@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560669967-23706-1-git-send-email-merez@codeaurora.org> References: <1560669967-23706-1-git-send-email-merez@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Dedy Lansky Replace sprintf with snprintf which checks the destination buffer size. Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/debugfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 14778a1c..8eb6d49 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -976,9 +976,8 @@ static ssize_t wil_read_pmccfg(struct file *file, char __user *user_buf, " - \"alloc \" to allocate pmc\n" " - \"free\" to free memory allocated for pmc\n"; - sprintf(text, "Last command status: %d\n\n%s", - wil_pmc_last_cmd_status(wil), - help); + snprintf(text, sizeof(text), "Last command status: %d\n\n%s", + wil_pmc_last_cmd_status(wil), help); return simple_read_from_buffer(user_buf, count, ppos, text, strlen(text) + 1); -- 1.9.1