Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: RE: [PATCH] ath10k: add mic bytes for pmf management packet
Thread-Topic: [PATCH] ath10k: add mic bytes for pmf management packet
From:   Wen Gong <wgong@qti.qualcomm.com>
To:     Ben Greear <greearb@candelatech.com>,
        Wen Gong <wgong@codeaurora.org>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Thread-Index: AQHVJSZMyCLP3ilNoE660R+W056916ahAcmw
Date:   Tue, 18 Jun 2019 07:21:30 +0000
Message-ID: <9403fef58374427fa76fb32ee64ee333@aptaiexm02f.ap.qualcomm.com>
References: <1560757079-19266-1-git-send-email-wgong@codeaurora.org>
 <136d04d4-671b-8dde-2abd-63070b07bd26@candelatech.com>
In-Reply-To: <136d04d4-671b-8dde-2abd-63070b07bd26@candelatech.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Ben
> Greear
> Sent: Tuesday, June 18, 2019 12:04 AM
> To: Wen Gong <wgong@codeaurora.org>; ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] Re: [PATCH] ath10k: add mic bytes for pmf management
> packet
>=20
> I was looking at mac80211 code recently, and it seems some action
> frames are NOT supposed to be protected.  I added my own helper
> method to my local ath10k.  Maybe you want to use this?
>=20
>=20
> /* Copied from ieee80211_is_robust_mgmt_frame, but disable the check for
> has_protected
>   * since we do tx hw crypt, and it won't actually be encrypted even when=
 this
> flag is
>   * set.
>   */
> bool ieee80211_is_robust_mgmt_frame_tx(struct ieee80211_hdr *hdr)
> {
>          if (ieee80211_is_disassoc(hdr->frame_control) ||
>              ieee80211_is_deauth(hdr->frame_control))
>                  return true;
>=20
>          if (ieee80211_is_action(hdr->frame_control)) {
>                  u8 *category;
>=20
>                  /*
>                   * Action frames, excluding Public Action frames, are Ro=
bust
>                   * Management Frames. However, if we are looking at a Pr=
otected
>                   * frame, skip the check since the data may be encrypted=
 and
>                   * the frame has already been found to be a Robust Manag=
ement
>                   * Frame (by the other end).
>                   */
> 		/*
> 		if (ieee80211_has_protected(hdr->frame_control))
>                          return true;
> 		*/
>                  category =3D ((u8 *) hdr) + 24;
>                  return *category !=3D WLAN_CATEGORY_PUBLIC &&
>                          *category !=3D WLAN_CATEGORY_HT &&
>                          *category !=3D WLAN_CATEGORY_WNM_UNPROTECTED &&
>                          *category !=3D WLAN_CATEGORY_SELF_PROTECTED &&
>                          *category !=3D WLAN_CATEGORY_UNPROT_DMG &&
>                          *category !=3D WLAN_CATEGORY_VHT &&
>                          *category !=3D WLAN_CATEGORY_VENDOR_SPECIFIC;
>          }
>=20
>          return false;
> }
>=20
> Thanks,
> Ben
>=20
> > +
> >   	data_len =3D msdu->len;
> >
> >   	switch (txmode) {
> >
>=20
>=20
Thanks Ben,

seems the ieee80211_is_robust_mgmt_frame_tx is not=20
match my change.