Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1586114ybi; Wed, 19 Jun 2019 23:59:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYne+OT7zf9RinHUvSYmONU3+UZy5OiGAnKcQqVnQZ/ael6nQF7zWTTQhd6mX4Gkr8z1GV X-Received: by 2002:a17:902:b611:: with SMTP id b17mr71756796pls.261.1561013975549; Wed, 19 Jun 2019 23:59:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561013975; cv=none; d=google.com; s=arc-20160816; b=W0JK/2euOjRkzOz6qdMoL/P5OgIO7yZCXdxV1bGemse4A4PSmpTBDIwopinOAM+ei9 0015+qFQRZoqmSkVtgJUolKIZGkUPz28Lz9At/8yvKw86OHUZLjLsFoBKEQ2OQkYUJyl odDgCnPEgnk5+Xyk+9r7XBNrt7gbcfw/gvpmpRfeom+EzX1s/8lii6ecCs9Ifv95GYdE rVMqwqJ8udbWbkJ4DbpflLWcpdSps9v6F0y+ULW5RR1SC9zMc5s4B0gEHHj5NRNq4fcy ReurvSD9LOY8TPdypJN2ekT7pBna/mlHjl8NEeP1UsruYt+ESHsi8yPYTm91zwpKSzAe MIBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=2BbW6lFj7CNrKeKHGpyDHZgCxsFJ8Rw7qjTCL/gfYEA=; b=I3WsyAV/DAOiIXHNGifmNJowkPJuju/fbZ0L6ArfJSDRewojPmQDWCKFU+4l3tjVst BjkvEBbZE9tImALzevbiX0MkB9aSedk/E/pDXXWHbYr/kI9mHmOoAYevO2h/opI/gDq5 +f2kj2eTgURtL+8ybZ+xpBBjOm98m74Q78D0mWpuH8scz6TmIKg/8TuWWYCdbOlik+LV JvLoXldF/RpSFdgbm+RHuReKcOkqOUBGRS9qHIDmwWU4M0+iTCAeSXd5E8oThNDkzUOi 4LSHg6rNBOssci4Djv8iDPNVshaC1lhtNhTwbmzDEhk0Y6ttff0DEs0AV433M86yt1VS vyCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d92si18465467pld.262.2019.06.19.23.59.06; Wed, 19 Jun 2019 23:59:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726170AbfFTG6w (ORCPT + 99 others); Thu, 20 Jun 2019 02:58:52 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:59172 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbfFTG6w (ORCPT ); Thu, 20 Jun 2019 02:58:52 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hdr22-0005gM-Ow; Thu, 20 Jun 2019 08:58:50 +0200 Message-ID: Subject: Re: [PATCH 3/3] nl80211: Include wiphy address setup in NEW_WIPHY From: Johannes Berg To: Denis Kenzior Cc: linux-wireless@vger.kernel.org Date: Thu, 20 Jun 2019 08:58:49 +0200 In-Reply-To: <20190619223606.4575-3-denkenz@gmail.com> (sfid-20190620_003639_356445_BEE1812F) References: <20190619223606.4575-1-denkenz@gmail.com> <20190619223606.4575-3-denkenz@gmail.com> (sfid-20190620_003639_356445_BEE1812F) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Didn't really review all of this yet, but switch (state->split_start) { > case 0: > + if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, > + rdev->wiphy.perm_addr)) > + goto nla_put_failure; We generally can't add anything to any of the cases before the split was allowed, for compatibility with old userspace. johannes